react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

updated babel package names and commands

Open tahseenio opened this issue 3 years ago • 8 comments

#4475

I have looked at the comments made by @harish-sethuraman and @invinciblejackalope and have updated the outdated package names where necessary.

tahseenio avatar May 03 '22 14:05 tahseenio

Hi @tahseenio!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar May 03 '22 14:05 facebook-github-bot

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn/add-react-to-a-website 59.42 KB (-2 B) 154.61 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] avatar May 03 '22 14:05 github-actions[bot]

Can you sign the CLA please?

I have submitted the CLA agreement about an hour ago but it has not yet updated. How can I fix this?

tahseenio avatar May 03 '22 15:05 tahseenio

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar May 03 '22 16:05 facebook-github-bot

@harish-sethuraman The PR is ready for approval

tahseenio avatar May 03 '22 16:05 tahseenio

Hey! I was @invinciblejackalope and opened the original issue. Thanks for writing the PR @tahseenio - wonder why this PR was closed? It doesn't seem like it was merged. It's my first time contributing so I'm just curious; not sure if this was intentional. @harish-sethuraman

jerzh avatar Jul 03 '22 04:07 jerzh

Im not sure how and why this got closed either. Re opening this pr. PS: Id like to get more opinion before merging so waiting :)

harish-sethuraman avatar Jul 03 '22 05:07 harish-sethuraman

Bump @gaearon? Sorry about the ping, just hoping that this doesn't get forgotten. It's a very simple package name update that would've saved me quite a bit of debugging.

jerzh avatar Jul 27 '22 07:07 jerzh