react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

The "Support Ukraine 🇺🇦" banner should disappear when scrolling

Open hslee2008 opened this issue 2 years ago • 12 comments

The point of this banner

The reason the banner exists is to help people notify that there is a way to help Ukraine people. However, making them permanent is not helping as it can intefere with the reading.

The problem

  1. Scrolling through contents is very hard to do because of the banner
  2. Reading the contents are harder as the banner takes up to 10% to 50% of the existing mobile page
  3. If people first look at the banner, they will either help or not help and they won't be likely to change their mind as they scroll through the contents.

How to fix

I believe it is right to make the banner disappear when scrolling through contents like React Native Website. Comparing two websites, the website looks much better without the banner when scrolling.

Clarification

I am not stating that the banner should be removed, only suggesting it should disappear when scrolled. It is much more better to learn when the banner is not present every time in computers. phones, and ipads.

Screenshots comparison

react reactfixed

hslee2008 avatar May 01 '22 11:05 hslee2008

I would like to work on this issue, let me raise a PR

nurbashanghai avatar May 30 '22 03:05 nurbashanghai

I would like to work on this issue, let me raise a PR

If you do, please mention it in this issue.

hslee2008 avatar May 30 '22 22:05 hslee2008

yes, im currently working on it, will raise pr later today

nurbashanghai avatar May 31 '22 03:05 nurbashanghai

https://github.com/reactjs/reactjs.org/pull/4713 this is my pull request

nurbashanghai avatar May 31 '22 08:05 nurbashanghai

Works perfectly.

hslee2008 avatar May 31 '22 09:05 hslee2008

Uploading SAVE_20220529_155236.jpg…

Rayanysilva12777 avatar Jun 05 '22 01:06 Rayanysilva12777

Eu

Rayanysilva12777 avatar Jun 05 '22 01:06 Rayanysilva12777

Quero ver meus arquivos messa foto

Rayanysilva12777 avatar Jun 05 '22 01:06 Rayanysilva12777

Please upload the picture again and use english, please for the majority.

hslee2008 avatar Jun 05 '22 02:06 hslee2008

I need to see . behold I need to see my files for this photo

Rayanysilva12777 avatar Jun 05 '22 02:06 Rayanysilva12777

is someone working on this issue?

aniket1010 avatar Jul 16 '22 12:07 aniket1010

Yes there are already two PRs for this issue.

harish-sethuraman avatar Jul 16 '22 12:07 harish-sethuraman

closed by https://github.com/reactjs/reactjs.org/pull/5002

harish-sethuraman avatar Sep 07 '22 05:09 harish-sethuraman