react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Update recommended React toolchains, add Vite.

Open leerob opened this issue 3 years ago • 12 comments

This PR was sparked by this comment in the CRA repo: https://github.com/facebook/create-react-app/issues/11180#issuecomment-874748552

Starting with 2.0, it’s [CRA] mostly in maintenance mode and does not strive to be the best tool for production React apps. It is a tool to get started and get something running fast. Perhaps, it’s not even best at that anymore.

I've updated the docs to reflect this. I've also tried to remove words like "popular" (describing Next.js) and "best" (describing Gatsby) to be more unopinionated. I tried to be as unbiased as possible, so please suggest any changes that could make this more clear.

leerob avatar Aug 03 '21 17:08 leerob

Hi @leerob!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Aug 03 '21 17:08 facebook-github-bot

✔️ Deploy Preview for reactjs ready! Built without sensitive environment variables

🔨 Explore the source changes: 2a7455c53a881944e666a58a95d6df8399e3d92d

🔍 Inspect the deploy log: https://app.netlify.com/sites/reactjs/deploys/61097f17560765000794225d

😎 Browse the preview: https://deploy-preview-3828--reactjs.netlify.app

netlify[bot] avatar Aug 03 '21 17:08 netlify[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Aug 03 '21 18:08 facebook-github-bot

Thanks for your contribution—it's very close to the new page for the new site! We were considering updating the current content, but now we will have to consider just merging your contribution!

rachelnabors avatar Aug 04 '21 12:08 rachelnabors

@rachelnabors Anything else you need from me here?

leerob avatar Aug 19 '21 14:08 leerob

Is there a chance we could get Vite listed under "The React team primarily recommends these solutions" alongside create-react-app? It has a lot of overlap with CRA's use case so it's a useful alternative (mainly because it's faster and has plugins), but CRA is still useful for more advanced use cases and older apps, so IMO we should recommend both so users can decide which fits their use case better.

nickserv avatar Sep 16 '21 04:09 nickserv

Hey @rachelnabors! Wanted to check in here. Anything more you need from me?

leerob avatar Feb 03 '22 23:02 leerob

Can you rebase your changes please?

harish-sethuraman avatar Feb 04 '22 03:02 harish-sethuraman

@harish-sethuraman done, thank you!

leerob avatar Feb 05 '22 18:02 leerob

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

github-actions[bot] avatar Feb 05 '22 18:02 github-actions[bot]

How do you feel about the messaging on the new site? I think it's confusing that we have the newer messaging there, and now we have an intermediate version. Would this PR still be valuable after the beta website ships?

gaearon avatar Feb 07 '22 19:02 gaearon

From the new messaging:

If you’re just getting started with React, we recommend Create React App, the most popular way to try out React’s features and a great way to build a new single-page, client-side application. Create React App is an unopinionated toolchain configured just for React.

My only confusion is that this seems to conflict with this comment.

Starting with 2.0, it’s [CRA] mostly in maintenance mode and does not strive to be the best tool for production React apps. It is a tool to get started and get something running fast. Perhaps, it’s not even best at that anymore.

leerob avatar Feb 21 '22 00:02 leerob

@leerob Hi, was closing this intentional?

nickserv avatar Sep 11 '22 03:09 nickserv

Oh whoops, yeah I forgot that would happen. I was cleaning up my mess of forked repos.

I'll defer to Dan – happy to roll this forward to the news docs site.

leerob avatar Sep 11 '22 17:09 leerob