react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Restyle logo width to make translations easier

Open tesseralis opened this issue 5 years ago • 9 comments

Currently, the width of the logo is fixed at calc(100% / 6) so that the nav links are flush with the search bar:

Screen Shot 2019-03-12 at 7 33 34 PM

Unfortunately, this leads to cut-offs in some translations with longer words in the nav bar:

Screen Shot 2019-03-12 at 7 38 26 PM

We're currently solving this by just adjusting the width of the logo, but it would be nice to have a solution that doesn't require hard-coding the logo width (e.g. just making the nav bar flush against the search bar)

I'll probably fix it myself when I have time but I figured I'd put this up here in case anyone wants to take a look.

tesseralis avatar Mar 13 '19 02:03 tesseralis

Hi, I would be interested in taking a look at this issue. Thanks!

kevjin avatar Mar 25 '19 03:03 kevjin

Added PR #1860 for review, thank you!

kevjin avatar Mar 25 '19 06:03 kevjin

same issues repo vi.reactjs.org After translate to vietnamese full_content

tuantvk avatar Jun 20 '19 08:06 tuantvk

@tesseralis @tuantvk Hello, I would like to work on this issue. This will be my first contribution to oss. @kevjin You have worked on this issue before, would you mind if I took over?

nigiiro-taro avatar Aug 25 '21 10:08 nigiiro-taro

@nigiiro-taro go ahead give it a try.

akgupta0777 avatar Sep 28 '21 05:09 akgupta0777

Thank you. I try it!

nigiiro-taro avatar Oct 05 '21 01:10 nigiiro-taro

@tesseralis @akgupta0777 I sent a pull request. If possible, could you please give me a review or comment?

nigiiro-taro avatar Oct 06 '21 06:10 nigiiro-taro

is this issue resolved i ? I would like to work on this issue

abhay27chauhan avatar Jan 30 '22 08:01 abhay27chauhan

is this issue resolved ? . Can i please know the status of the issue so that i can take over it?

yashbujji avatar Jun 12 '22 19:06 yashbujji

Is this something worked on by someone? Can I make a PR?

lakshmi930 avatar Sep 29 '22 21:09 lakshmi930

Please note that we're going to replace this site with https://beta.reactjs.org/ soon so we don't really plan to make changes to the old one.

harish-sethuraman avatar Oct 04 '22 19:10 harish-sethuraman