react-transition-group icon indicating copy to clipboard operation
react-transition-group copied to clipboard
verified publisher icon reactjs

Incorrect implementation of onTransitionEnd

Open X-Y opened this issue 1 year ago • 0 comments

What is the current behavior?

addEndListener on Transition has two arguments, node and done. node is a function and done is undefined.

What is the expected behavior?

node should be the nodeRef and done should be a function

Look at this line: https://github.com/reactjs/react-transition-group/blame/2989b5b87b4b4d1001f21c8efa503049ffb4fe8d/src/Transition.js#L350

if this.props.nodeRef exists, then maybeNode becomes this.nextCallback and maybeNextCallback becomes undefined?

Could you provide a CodeSandbox demo reproducing the bug?

X-Y avatar Dec 04 '24 14:12 X-Y