react-transition-group icon indicating copy to clipboard operation
react-transition-group copied to clipboard

how to set dynamic animations?

Open jasonintju opened this issue 8 years ago • 13 comments

I am using react-transition-group v2.2.0 and react-router v4.1.1 to do the page sliding animation. Once a component is mounted, its exit animation is specified, not changeable, which troubles me.

function getPathDepth(location) {
  let pathArr = (location || {}).pathname.split('/');
  pathArr = pathArr.filter(n => n !== '');
  return pathArr.length;
}

class Routers extends React.Component {
  constructor(props, context) {
    super(props, context);
    this.state = {
      prevDepth: getPathDepth(props.location)
    };
  }

  componentWillReceiveProps() {
    console.log('prev:', getPathDepth(this.props.location));
    this.setState({ prevDepth: getPathDepth(this.props.location) });
  }

  render() {
    return (
      <Route render={({ location }) => 
          <TransitionGroup>
            <CSSTransition
              key={location.key}
              timeout={500}
              classNames={ getPathDepth(location) - this.state.prevDepth > 0 ? 'pageSliderLeft' : 'pageSliderRight' }
              classNames={classNames}
              mountOnEnter={true}
              unmountOnExit={true}
            >
              <Switch location={location}>
                <Route path="/" exact component={ Index } />
                <Route path="/comments" component={ Comments } />
                <Route path="/opinions" component={ Opinions } />
                <Route path="/games/lol" component={ LOL } />
                <Route path="/games/dota" component={ DotA } />
                <Route path="/games" component={ Games } />
              </Switch>
            </CSSTransition>
          </TransitionGroup>
      } />
    )
  }
}

const WrapRouters = withRouter(Routers);

export default function RouterMap() {
  return (
    <BrowserRouter>
      <WrapRouters />
    </BrowserRouter>
  );
}

The css:

.pageSliderRight-enter {
  transform: translate3d(-100%, 0, 0);
}
.pageSliderRight-enter.pageSliderRight-enter-active {
  transform: translate3d(0, 0, 0);
  transition: all 600ms;
}
.pageSliderRight-exit {
  transform: translate3d(0, 0, 0);
}
.pageSliderRight-exit.pageSliderRight-exit-active {
  transform: translate3d(-100%, 0, 0);
  transition: all 600ms;
}

.pageSliderLeft-enter {
  transform: translate3d(100%, 0, 0);
}
.pageSliderLeft-enter.pageSliderLeft-enter-active {
  transform: translate3d(0, 0, 0);
  transition: all 600ms;
}
.pageSliderLeft-exit {
  transform: translate3d(0, 0, 0);
}
.pageSliderLeft-exit.pageSliderLeft-exit-active {
  transform: translate3d(100%, 0, 0);
  transition: all 600ms;
}

The animation:

pageslidinganimation3

If only sliding from '/' to '/games' and then from '/games' back to '/', everything is fine. But with more routes, it gets complicated.

For the Games component:

  • type 1: '/' --> '/games' && '/games' --> '/', exit animation should be 'slide to right'
  • type 2: '/' --> '/games' && '/games' -->'/games/lol', exit animation should be 'slide to left'

As the Games component mounted, its exit animation classNames is 'pageSliderLeft' or 'pageSliderRight'. No matter which class, there is only one animation. But Games component has two exit types.

How to make the Games component's exiting show different animations?

jasonintju avatar Aug 31 '17 11:08 jasonintju

This is a typical unmounting animation problem, I've run into it before. My solution back then was to call setState to update the classNames first, such that the exit animation will be up to date, and then set a timer with 0 delay to update the in states to trigger the exit animation. Not pretty, but working.

Chopinsky avatar Aug 31 '17 22:08 Chopinsky

yeah the issue is that you can't really change the animations on an item from the outside the "normal" way because you unrender it. There is the childFactory prop for addressing this, which is called with the item and the state even for the items you don't "see" anymore

jquense avatar Aug 31 '17 23:08 jquense

For anyone else that finds their way here - there's a great Q&A on StackOverflow with a detailed explanation on how to use childFactory: https://stackoverflow.com/questions/41404232/react-transitiongroup-and-react-cloneelement-do-not-send-updated-props

m-allanson avatar Oct 06 '17 16:10 m-allanson

@Chopinsky I'm not sure I follow. Could you paste an example demonstrating how you achieved that?

pmcalmeida avatar Nov 01 '17 19:11 pmcalmeida

childFactory is definitely the way to go. Thanks to the SO link provided by @m-allanson, I was able to use the childFactory as follows to correctly update the animation:

//This returns a childFactory to provide to TransitionGroup
const childFactoryCreator = (classNames) => (
  (child) => (
    React.cloneElement(child, {
      classNames
    })
  )
);

<TransitionGroup
  childFactory={childFactoryCreator(condition ? "anim1" : "anim2)}
>
  <CSSTransition
     key={key}
     classNames={condition ? "anim1" : "anim2"}
  >
     //Item that gets transitioned goes here
  </CSSTransition>
</TransitionGroup>

cjnaude avatar Dec 05 '17 08:12 cjnaude

@cjnaude Does this really work with React 16 and React Transition Group v2?

  1. Personnally I couldn't get it to work.
  2. The SO answer is from Dec 31 '16.

marshall-cho avatar Feb 27 '18 21:02 marshall-cho

@marshall-cho Here are my dependencies: "react": "^16.2.0" "react-transition-group": "^2.2.1"

Are you getting any specific errors, or is the animation just not updating?

TapX avatar Feb 28 '18 08:02 TapX

I just wanted to share an article I just wrote dealing with this issue: https://medium.com/lalilo/dynamic-transitions-with-react-router-and-react-transition-group-69ab795815c9. This thread helped me a lot. Thanks

nicgirault avatar Mar 08 '18 22:03 nicgirault

@nicgirault Greate article. The part of providing the immutable location to the switch made me smile :smile: I'm going to explore your example's source code, it looks great! Thank you.

sag1v avatar Mar 16 '18 19:03 sag1v

https://codesandbox.io/s/p93vp612w0 Heres a sandbox app with my implementation if anyones struggling with this.

moneydance avatar Jan 30 '19 07:01 moneydance

If anyone else is struggling with this problem, the way we fixed it was to wrap the entire <SwitchTransition> inside a div. Then when we want the components to slide in either direction we dynamically change the class of that parent div which targets (selects) the classes of the child elements inside the transition component. That way the classes inside the transition stay static while the classes of parent div change thereby controlling the direction of the transitions using CSS selectors.

johnbonds avatar Oct 30 '20 21:10 johnbonds

@nicgirault Thanks for the article mate, I was really struggling to get this right

cjke avatar Nov 20 '20 12:11 cjke

2022 and the issue is still here!

Solved by example of @moneydance (comment above): thanks a lot, you saved my day!

One-string solver:

const dynamicChildFactory = classNames => child => React.cloneElement(child, { classNames });

chupzzz avatar May 19 '22 21:05 chupzzz