react-rails
react-rails copied to clipboard
Warn on old js runtimes
Closes #948
Summary
Added a check to see what node version is being used in railtie.rb
. I am not a ruby/rails dev, but after some looking this seemed like an early spot to run this check. I made a custom color function as opposed to adding a library like this one I found.
I also matched the engines in the package.json
to those in webpacker
Other Information
A concern I would have is if this library is expected to work on non *nix environments. If that is the case then the shell commands I wrote would not work. In the node world, I would use a library like shelljs to handle multiple operating systems. Not sure about how this is handled in ruby.
Please let me know if that is a problem and I will fix it.
Thanks!
Todo
- [ ] Update to not call shell
@BookOfGreg Wow this one got lost in the sauce. Coincidently, I now work in ruby/rails at my current job. I will see this one to the end. Hope you are staying safe!
These things do get lost but it's not a big deal. I use these projects in waves too, so I also go a few months without checking in on them depending on the project I'm on. Hope you are well!
Updated the PR; however, travis is failing. Looks like it is because master build is broken
Yep, annoyingly this project is very exposed to the JavaScript treadmill so anytime we're prepping for a release we have to sort all the JS deps all over again. Thanks for your work, I'll take a look at this one for the next release, not sure when that will be though.
@justin808, We can close this PR. The file lib/react/rails/js_runtime_checker.rb
was removed.