react-rails icon indicating copy to clipboard operation
react-rails copied to clipboard
verified publisher icon reactjs

Deprecation warnings in dummy apps

Open ttanimichi opened this issue 7 years ago • 3 comments 

$ bundle exec appraisal rake test 2>&1 | grep -i deprecation
DEPRECATION WARNING: `secrets.secret_token` is deprecated in favor of `secret_key_base` and will be removed in Rails 6.0. (called from block in <class:ServerRenderedHtmlTest> at /Users/tanimichi.tsukuru/ghq/github.com/reactjs/react-rails/test/server_rendered_html_test.rb:97)
DEPRECATION WARNING: `config.static_cache_control` is deprecated and will be removed in Rails 5.1.
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: `config.static_cache_control` is deprecated and will be removed in Rails 5.1.
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
.DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: `config.static_cache_control` is deprecated and will be removed in Rails 5.1.
..................DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: `config.static_cache_control` is deprecated and will be removed in Rails 5.1.
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
.DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
DEPRECATION WARNING: `config.static_cache_control` is deprecated and will be removed in Rails 5.1.

ttanimichi avatar Aug 06 '18 06:08 ttanimichi

  • [ ] config.static_cache_control is deprecated and will be removed in Rails 5.1.
  • [ ] secrets.secret_token is deprecated in favor of secret_key_base and will be removed in Rails 6.0.
  • [ ] Using positional arguments in functional tests has been deprecated

ttanimichi avatar Aug 06 '18 06:08 ttanimichi

I'm not sure we can remove those deprecation warnings as long as we support those Rails versions as the dummies are already crushed up to support multiple gemfiles. I suppose when Rails 6 comes out we may need to remove another older rails, or split the tests further.

I was wondering as a longer-term measure, is there a better way than having multiple dummy-apps for different rails versions? I might go look at other gems to see how they do it. I remember checking in the past and most other gems just don't bother or unit test against the interface.

BookOfGreg avatar Aug 06 '18 08:08 BookOfGreg

Oh, I understand. It sounds difficult to fix those deprecation warnings...

is there a better way than having multiple dummy-apps for different rails versions?

I'm also not familiar with it, but kaminari-core looks like having a better way to support multiple rails versions. They don't have dummy apps although they have multiple gemfiles like us.

I suppose when Rails 6 comes out we may need to remove another older rails

Yeah, I agree with you. When Rails 6 comes out, maybe Rails core team will drop support for Rails 5.1, so we may not need to support it, too. Someday, I want to drop sprockets' support, too :joy: In Rails 6, Webpacker seems to be the default JavaScript compiler.

ttanimichi avatar Aug 06 '18 11:08 ttanimichi