react-rails icon indicating copy to clipboard operation
react-rails copied to clipboard

Rails 7 support

Open JensDebergh opened this issue 2 years ago • 5 comments

Hi

I was wondering if there are any plans to upgrade react-rails to rails 7.0.

I would like to update my application to the newest version but I am stuck due to react-rails dependency on 6.1.x

Kind regards Jens

JensDebergh avatar Feb 15 '22 08:02 JensDebergh

My apologies, support has been merged into master, I'm currently trying to drum up additional maintainers to help ensure that releases are properly supported. If you use this at your work, can you please consider asking for open-source volunteer time to help support projects like this one? See also: https://github.com/reactjs/react-rails/issues/1129#issuecomment-1041476088

BookOfGreg avatar Feb 16 '22 13:02 BookOfGreg

Does this gem work with Rails 7 and if so, can you update the README's instructions with info about Rails 7? It seems unclear to me whether it does and how to make it work if so.

pickhardt avatar Jul 17 '22 22:07 pickhardt

@BookOfGreg what's a good test app to try this with Rails 7?

I posted this issue: https://github.com/BookOfGreg/react-rails-example-app/issues/57

justin808 avatar Aug 09 '22 07:08 justin808

Does this gem work with Rails 7 and if so, can you update the README's instructions with info about Rails 7? It seems unclear to me whether it does and how to make it work if so.

I have it working with Rails 7 & Webpacker. Following the instructions in the README for rails versions < 6.0 should also work with rails 7. If you don't want to be using Webpacker then I'm not sure but maybe this will help someone.

I had to replace:

## application.html.erb
<%= javascript_importmap_tags %>

with:

## application.html.erb
<%= javascript_pack_tag 'application' %>

hdpuk86 avatar Aug 09 '22 20:08 hdpuk86

@hdpuk86 If you can submit a PR, I'll promptly review and merge.

justin808 avatar Aug 12 '22 08:08 justin808

@hdpuk86, Can you please raise a PR for this?

alkesh26 avatar Oct 07 '22 12:10 alkesh26

+1

thadeu avatar Nov 18 '22 20:11 thadeu

@justin808 Should I work on this?

ahangarha avatar Nov 19 '22 20:11 ahangarha

I want to confirm if we need anything to do other than add instructions to the documentation.

ahangarha avatar Apr 25 '23 18:04 ahangarha

was fixed a long time ago.

justin808 avatar Jul 14 '23 21:07 justin808