react-modal

react-modal copied to clipboard

Question: will setAppElement(document.body) work as expected?

4

As I understand it, `setAppElement()` is needed so everything in the background, behind the modal, will be set to "hidden" for screen readers. The documentation specifies that `setAppElement()` should be...

vincerubinetti

Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.0. Changelog Sourced from log4js's changelog. 6.4.0 security: default file permission to be 0o600 instead of 0o644 - thanks ranjit-git and @​peteriman chore(docs): updated fileSync.md...

dependabot[bot]

[added] update README regarding onAfterOpen and Jest

1

Changes proposed: - Providing an additional section in the README related to the post v3.14.1 change to the behavior of the `onAfterOpen` prop and how it can break Jest tests...

postrad

Cannot tab in react-testing-library

5

### Summary: When writing tests using react-testing-library, tabbing does not work properly when inside of a react-modal. ### Steps to reproduce: 1. Render a Modal with some tabbable elements 2....

danny-does-stuff

ReactModal focuses on last input/button when modal closes

7

### Summary: When the modal is closed it focuses on the last focused input field/button. This is unexpected and not clearly documented. I had a button that was only visible...

trevlar

### Summary: Input label is not being read by VoiceOver inside modal and in Safari only. Input label's outside read correctly. Labels in modal are read correctly in Chrome. Issue...

rayon21

htmlOpenClassName overflow:hidden; causes page to scroll to top when opening modal

1

To prevent background scrolling when the modal is open I used `htmlOpenClassName` to add `overflow: hidden;` which is the only solution that worked, but unfortunately this causes the page to...

amol0900

Issue with stopPropagation

8

### Summary: When an element in a modal calls `stopPropagation` on the click event, it seems the first click on the overlay does not close the modal. ### Steps to...

marcselman

Rendering multiple modals

10

### Summary: I have a grid of products, each with its own modal for quick shop functionality. I came across this issue, that suggests to conditionally render the modal. However,...

wheredannyends

Discussion for v4 of react-modal

13

First, thanks for all the support through the years...reporting and answering issues, or submitting PRs. You guys are great. I try my best to find time to help improve this...

diasbruno