react-magic icon indicating copy to clipboard operation
react-magic copied to clipboard

Added onclick=> onClick to ATTRIBUTE_MAPPING

Open nvh95 opened this issue 8 years ago • 3 comments

Added onclick=> onClick to ATTRIBUTE_MAPPING. Because when transform onclick from HTML to Javascript React it will be onClick (refer to this link https://reactjs.org/docs/handling-events.html) screen shot 2017-11-22 at 10 13 31 am

nvh95 avatar Nov 22 '17 03:11 nvh95

Deploy preview ready!

Built with commit 1d52e8f1975e92033f62988a98cef4c6a32efac7

https://deploy-preview-150--react-magic.netlify.com

DanBuild avatar Nov 22 '17 03:11 DanBuild

Will this actually work properly? Won't it transform onclick="doFoo()" to onClick="doFoo" rather than onClick={doFoo}?

Daniel15 avatar Nov 27 '17 01:11 Daniel15

Much more to add in ATTRIBUTE_MAPPING => React SyntheticEvent

guitarneck avatar Jan 25 '18 09:01 guitarneck