react-chartjs icon indicating copy to clipboard operation
react-chartjs copied to clipboard

Options doesn't work with React 16

Open stelro opened this issue 7 years ago • 7 comments

Hello, I am using react-chartjs version 1.2.0 and chart.js 1.1.1 and I have upgraded my App to react.js 16 and I have some issues with react-chartjs.

When I was using the module with react 15, everything was working alright like in the picture below https://imgur.com/a/ueUOg But since I upgraded to React 16, the options object sees to have broke, nothing is working as expected https://imgur.com/MaFruaA .

Any suggestions?

stelro avatar Feb 03 '18 15:02 stelro

I was looking at the v16 changelog and it mentions some stuff was changed around with React's lifecycle, but it doesn't seem to be the case. Can't figure this out either.

tankorsmash avatar May 25 '18 00:05 tankorsmash

@stelro, can you please upload an example ?

Jareechang avatar May 25 '18 20:05 Jareechang

Any update on this?

katiawheeler avatar Aug 07 '18 13:08 katiawheeler

I have made this pen as an example and it is working fine https://codepen.io/agent3bood/pen/bmrbqp?editors=0010 If the issue something else please tell me so I can work on it.

agent3bood avatar Oct 12 '18 08:10 agent3bood

@agent3bood, I just added a few options that do not work to your codepen: https://codepen.io/anon/pen/MzjNQw?editors=0010

Hope this helps!

fdalvi avatar Nov 12 '18 07:11 fdalvi

@fdalvi I think you referring to some options in chart.js version 2. This library support only chart.js version 1.1.1, please refer the docs here https://github.com/chartjs/Chart.js/tree/v1.1.1/docs Here is an idea for you Instead of padding you can use offsetGridLines: True

agent3bood avatar Nov 12 '18 14:11 agent3bood

Thanks @agent3bood, you are absolutely correct! I actually switched to react-chartjs-2 since it uses the latest (and probably better supported) Chart.js library.

fdalvi avatar Nov 13 '18 06:11 fdalvi