react-art icon indicating copy to clipboard operation
react-art copied to clipboard

render mode is unconfigurable

Open fumihwh opened this issue 10 years ago • 5 comments

I have read the issue 17 and test source. https://github.com/reactjs/react-art/issues/17 https://github.com/reactjs/react-art/blob/master/src/tests/ReactART-test.js#L55-L59

And I think there is no way to change the render mode. In ReactART.js, there is requiring the art/modes/fast, that decide the mode used in ReactART. @sebmarkbage You said that is already configurable and already do this in the unit test. Actually L56-L59 in ReactART-test.js do nothing about ReactART Object.

I think you can just delete the L14 in ReactART.js, and let us choose the mode freely.

fumihwh avatar Aug 07 '15 08:08 fumihwh

I agree with @fumihwh. The unit test has access to the dependency's API directly, whereas any application built on top of this doesn't. Mode needs to be exposed in ReactART, along with the available modes (e.g. ReactART.AvailableModes.SVG). And ideally you could change the mode with a component property.

webxl avatar Sep 09 '15 23:09 webxl

@fumihwh + I'm also looking for a solution.

varghesep avatar Sep 17 '15 19:09 varghesep

+1. Would be great if the mode is configureable.

shripadk avatar Oct 03 '15 15:10 shripadk

+1

zemlanin avatar Oct 28 '15 20:10 zemlanin

+1 Also looking to have this configurable

andru avatar Jan 01 '16 19:01 andru