hi.react.dev icon indicating copy to clipboard operation
hi.react.dev copied to clipboard

Published 20 hours ago • verified publisher icon reactjs

Thinking in React : 3 paragraph translation done

Open kumard3 opened this issue 3 years ago • 12 comments
trafficstars

kumard3 avatar Jan 08 '22 16:01 kumard3

Hi @kumard3

can you make the changes which I have suggested, once those are done. please leave a comment here. So I can reivew and continue further review of the file.

arshadkazmi42 avatar Jan 09 '22 11:01 arshadkazmi42

Hi @kumard3

can you make the changes which I have suggested, once those are done. please leave a comment here. So I can reivew and continue further review of the file.

i think i have made all the requested changes

kumard3 avatar Jan 09 '22 12:01 kumard3

@kumard3 There are few missed and in few I had done one typo. Can you update those. Post that with can continue with review.

arshadkazmi42 avatar Jan 09 '22 15:01 arshadkazmi42

@kumard3 There are few missed and in few I had done one typo. Can you update those. Post that with can continue with review.

i have completed the translation of this page .

kumard3 avatar Jan 14 '22 19:01 kumard3

@kumard3 You have missed following comments, can you get these fixed

https://github.com/reactjs/hi.reactjs.org/pull/173#discussion_r780792526

https://github.com/reactjs/hi.reactjs.org/pull/173#discussion_r780740358

https://github.com/reactjs/hi.reactjs.org/pull/173#discussion_r780740524

arshadkazmi42 avatar Jan 15 '22 05:01 arshadkazmi42

Thank you for working on fixes.

Added review till line 59.

Can you get these also fixed, then we can continue further

i have resolved all the changes .

kumard3 avatar Jan 15 '22 14:01 kumard3

@kumard3 You can check my review comments above. I have mentioned wrong value and correct value at lines, you just need to do find and replace at that line

arshadkazmi42 avatar Jan 15 '22 16:01 arshadkazmi42

Added 3 more comments till line 79.

@kumard3 Most of the translation seems wrong, I have to change complete sentences in review.

Can you revisit the doc from line 80 once and cross check with english version and fix the obvious once? Atleast the sentences itself, most of the hindi version of sentences are not making sense.

i am having a confusion for top down what should i write ऊपर नीचे or टॉप डाउन and for compute what should i use कम्प्यूट or गणना करना

kumard3 avatar Jan 23 '22 05:01 kumard3

Added 3 more comments till line 79. @kumard3 Most of the translation seems wrong, I have to change complete sentences in review. Can you revisit the doc from line 80 once and cross check with english version and fix the obvious once? Atleast the sentences itself, most of the hindi version of sentences are not making sense.

i am having a confusion for top down what should i write ऊपर नीचे or टॉप डाउन and for compute what should i use कम्प्यूट or गणना करना

I am adding some more comments, you can make changes post that.

arshadkazmi42 avatar Jan 23 '22 05:01 arshadkazmi42

@kumard3 Please take a pull of your branch, I have made some fixes in the code

arshadkazmi42 avatar Jan 23 '22 05:01 arshadkazmi42

Hi @kumard3 Any updates?

Let me know if you need any help

arshadkazmi42 avatar Jun 25 '22 05:06 arshadkazmi42

Hi @kumard3 Any updates?

Let me know if you need any help

I am really sorry, will be completing it by next Sunday.

kumard3 avatar Jun 27 '22 04:06 kumard3

@kumard3 Can you resolve the conflict in the file? I will get this merged and we will take care of the commnets in a followup PR

arshadkazmi42 avatar Sep 30 '24 21:09 arshadkazmi42

@kumard3 Can you resolve the conflict in the file? I will get this merged and we will take care of the commnets in a followup PR

Sure.

kumard3 avatar Oct 01 '24 13:10 kumard3

@arshadkazmi42 the conflict is in the page that, does not exist in the main branch , can you guide me where i have to put it ?

kumard3 avatar Oct 01 '24 14:10 kumard3

ah ok. then I guess we can close this PR.

arshadkazmi42 avatar Oct 01 '24 18:10 arshadkazmi42