fa.react.dev icon indicating copy to clipboard operation
fa.react.dev copied to clipboard

Request to Transfer Maintainer of the fa.react.dev Repository

Open mrbadri opened this issue 8 months ago • 18 comments

Hello React Team,

As a small member of the Persian-speaking developer community, I am creating this issue regarding the fa.react.dev repository.

This repository appears to have been inactive for a long time, and the current maintainers are no longer actively managing it.

Given the importance of having official React documentation available in Persian, I kindly request that the Maintainer of this repository be transferred either to me or to another active contributor approved by the React team.

The goal is to help grow the React community among Persian-speaking developers and to improve access to accurate and up-to-date resources.

I am confident that the professional React team will carefully consider this request and continue to show the same respect and support for various language communities as it always has.

Thank you for your attention.

Best regards, Mohammad rza badri

mrbadri avatar Apr 28 '25 15:04 mrbadri

We are actively trying to revive the fa.react.dev repository in this issue. Join us and show your support: https://github.com/reactjs/react.dev/issues/7786

mrbadri avatar May 13 '25 17:05 mrbadri

@rezvani2647 @seven-deuce @sJJdGG @sorousht @zahrajoulaei are any of the current maintainers currently active and willing to help review PRs and/or add additional maintainers to help make progress translating the docs?

rickhanlonii avatar May 14 '25 13:05 rickhanlonii

@rickhanlonii I'm willing to help

sJJdGG avatar May 15 '25 04:05 sJJdGG

Hi @rickhanlonii , @sJJdGG 👋

I have created the following pull requests:

  • Persian Localization of Home Page and Key UI Elements
    https://github.com/reactjs/fa.react.dev/pull/466 This PR includes the translation of the home page, navigation, footer, and blog sidebar into Persian (rtl direction supported).

  • Fix: Correct overlay highlighting in code examples on react.dev
    https://github.com/reactjs/react.dev/pull/7669 This PR fixes the incorrect overlay highlighting in code examples and also ensures correct support for rtl direction when viewing the site in right-to-left languages.

I would appreciate it if you could review these pull requests. 🙏

mrbadri avatar May 15 '25 12:05 mrbadri

@sJJdGG thanks! cCould you review those PRs, and consider adding new maintainers if needed tom help make progress?

rickhanlonii avatar May 15 '25 14:05 rickhanlonii

Yeah, let's start by adding maintainers. I'm ok with adding @mrbadri PRs as a maintainer.

BTW @rickhanlonii , if we maintainers of the local translation decide to use AI for automations, would that be ok with you?

sJJdGG avatar May 15 '25 15:05 sJJdGG

@sJJdGG if it's reviewed by the maintainers that seems fine

rickhanlonii avatar May 15 '25 17:05 rickhanlonii

@mrbadri added you as a maintainer.

@masoud-bahrami is the only admin maintainer who can add more, @masoud-bahrami are you able to manage invites or should I add a new admin?

rickhanlonii avatar May 15 '25 17:05 rickhanlonii

Thank you, @rickhanlonii, for your attention and support on this. I look forward to contributing and being helpful to the project. 🙏

mrbadri avatar May 15 '25 18:05 mrbadri

@rickhanlonii , Pull requests require approval from a reviewer. Does this also apply to maintainers?

Currently, I am the only active maintainer, and there is no one else to approve my own pull requests.

Who can approve my pull requests?

Also, is there any document or guideline about the process and rules for pull requests? I’d be happy to review it if available.

https://github.com/reactjs/fa.react.dev/pull/466

mrbadri avatar May 15 '25 19:05 mrbadri

@mrbadri you can merge your own PR as a maintainer

sJJdGG avatar May 16 '25 09:05 sJJdGG

@sJJdGG Could you please tell me how I can do this?

Image Image Image

mrbadri avatar May 16 '25 11:05 mrbadri

@sJJdGG Could you please tell me how I can do this?

Image Image Image

@rickhanlonii @sJJdGG Could you please help me with this part? I would appreciate your guidance.

mrbadri avatar May 16 '25 19:05 mrbadri

@mrbadri I also can't approve your PR. Same error as you @rickhanlonii Seems like we're locked out

sJJdGG avatar May 16 '25 20:05 sJJdGG

The check_maintainer job is unrelated, the failing check is via the repo branch settings, which requires an approval:

Image

So one of the other maintainers needs to approve the PR. The only approval is from a person who doesn't have write access:

Image

As maintainers, you can choose to turn this option off so you can merge/approve your own PRs (we have this off in the main repo), but it's up to you all what processes you want to enforce.

rickhanlonii avatar May 17 '25 16:05 rickhanlonii

As an example, I've approved https://github.com/reactjs/fa.react.dev/pull/466, and it's now green to merge.

rickhanlonii avatar May 17 '25 16:05 rickhanlonii

I currently do not have access to the branch protection settings.

To proceed, we have two possible options: 1. Modify the branch protection rules to allow maintainers to approve and merge their own pull requests. 2. Add another active maintainer with the appropriate permissions to handle approvals.

Please let me know which course of action you’d prefer to take. @rickhanlonii

mrbadri avatar May 17 '25 16:05 mrbadri

@mrbadri maybe it wasn't clear but @sJJdGG is an active maintainer but they didn't approve your PR so that's why it couldn't merge. I think what you need is an additional admin, which is why I pinged @masoud-bahrami above. I'd see if you can get ahold of them to help manage maintainers/settings or to add additional admins.

rickhanlonii avatar May 17 '25 18:05 rickhanlonii

Looks like this is settled, let me know if there's anything else.

rickhanlonii avatar Oct 31 '25 15:10 rickhanlonii

@rickhanlonii @mrbadri Sorry about inconvenience I may have caused by my inaction.

@rickhanlonii Thank you for handling it, if anything I'd argue having more collaborators and consequently more activity would be top priority for reactjs/fa.react.dev even in the face of all possible non-desired outcomes since any move forward would be a positive outcome at the current status of the repo. as we say in Persian "به راه بادیه رفتن به از نشستن باطل" meaning “To set out upon the desert path is better than sitting idly and in vain.”

sJJdGG avatar Nov 03 '25 10:11 sJJdGG