ReactiveUI icon indicating copy to clipboard operation
ReactiveUI copied to clipboard

Get full coverage in our bench marks project.

Open glennawatson opened this issue 6 years ago • 11 comments

We should get a lot more coverage of different performance tests in our Benchmark project. So most major classes covered.

Extensions

Interactions

Observable Properties

Reactive Commands

glennawatson avatar Aug 28 '18 18:08 glennawatson

Lately, I’ve been interested by everything performance so this could be a fun thing! are we talking of adding micro-benchmarks with a benchmark.NET? What’s the scope?

Kavignon avatar Aug 22 '19 02:08 Kavignon

@kavignon if you want to help out this is probably a good starter task. Essentially we want a base line of most of our existing code base so we aren't going backwards in terms of performance. There is not a platform runner at the moment for benchmark dot net for Android iOS so I would focus on core functionality first that didn't exist in the platforms folder and work from there.

glennawatson avatar Aug 22 '19 05:08 glennawatson

You mention full coverage. How do I determine case coverage to make sure when I submit my PR, it makes sense with what you’d expect in the benchmark project?

Kavignon avatar Aug 23 '19 22:08 Kavignon

Yeah coverage is a bit tricky since as far as I know there isn't any automated tools. I was just going to go through each file in the src/ReactiveUI folder and produce a benchmark for it. I wouldn't do the Platform folder

glennawatson avatar Aug 23 '19 22:08 glennawatson

How about this idea; I’m going to close ReactiveUI and do a few benchmarks on my own. Then submit a PR for those and we can discuss on said PR what you would have like to see if I miss anything. When that portion is stable, I’ll get over the items I haven’t done beforehand. Sounds good?

Kavignon avatar Aug 23 '19 22:08 Kavignon

@Kavignon I'd recommend starting with one of the items above, there are 4 categories of benchmarks. I believe I have the ReactiveCommand started. Let me dust that branch off this weekend and submit a PR for it. Then you can just follow that PR for the remaining benchmarks. That way you don't invest too much effort. I'd recommend open a PR per category to keep it easier to manage. The bigger the PR the harder it is to review.

RLittlesII avatar Aug 23 '19 23:08 RLittlesII

That sounds pretty good in fact! let me know here when your PR is ready!

Kavignon avatar Aug 24 '19 00:08 Kavignon

@RLittlesII I saw what you did in #2151, I'll do the same. As we said, I'll do specific PRs per category and link them back in here!

Kavignon avatar Aug 27 '19 13:08 Kavignon

Adding ToProperty extension methods to the list.

RLittlesII avatar Sep 06 '19 21:09 RLittlesII

Hi may i can help , still open?

GmausDev avatar Oct 12 '22 20:10 GmausDev

@GmausDev definitely one we could use help with

glennawatson avatar Oct 12 '22 22:10 glennawatson