[DO NOT MERGE]: IKeyValueCollection as IReadOnlyList

[kronic]

Implement IKeyValueCollection as IReadOnlyList

[dwcullop]

Please add some description to your PR (describe what you are changing and why). It doesn't have to be long, but it is for posterity.

[JakenVeina]

Looks like the build failures are complaining about calling LINQ methods on objects that now support direct calls (E.G. .Count() versus .Count), and only in Tests code. Another case of the analyzers being overly-aggressive, probably, but should be an easy fix. Do those errors not show up on your end?

[dwcullop]

Looks like the build failures are complaining about calling LINQ methods on objects that now support direct calls (E.G. .Count() versus .Count), and only in Tests code. Another case of the analyzers being overly-aggressive, probably, but should be an easy fix. Do those errors not show up on your end?

I'm guessing he might not if he's using ReSharper and not VS. The build failures on the server can show what changes need to be made.

[glennawatson]

Rider will have the same build errors as VS. The analysers work on both. Use rider all the time.

[kronic]

@dwcullop @glennawatson @JakenVeina ready for review

[kronic]

@JakenVeina done

[RolandPheasant]

@JakenVeina let's hold back a couple weeks on merging this, so we can apply other breaking changes as part of a big version release.

[kronic]

@RolandPheasant ping

[github-actions[bot]]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.