openai-webflux-java icon indicating copy to clipboard operation
openai-webflux-java copied to clipboard

[FR] make the ChoiceData record public

Open serrafrank opened this issue 1 year ago • 4 comments

Is your feature request related to a problem? Please describe. the record io.github.reactiveclown.openaiwebfluxclient.client.chat.ChoiceData.java is not directly accessible..

'io.github.reactiveclown.openaiwebfluxclient.client.chat.ChoiceData' is not public in 'io.github.reactiveclown.openaiwebfluxclient.client.chat'. Cannot be accessed from outside package

Describe the solution you'd like You should add the public keyword

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

serrafrank avatar May 16 '23 12:05 serrafrank

Hi @serrafrank thank you for oppening this issue and using my library. I will take a look on this FR tomorrow and will keep you updated.

reactiveclown avatar May 24 '23 19:05 reactiveclown

Hi @reactiveclown, any updates on this? The library seems unusable without this being public...

OpenSource03 avatar Aug 12 '23 21:08 OpenSource03

I've opened a pull request that should fix this issue :)

OpenSource03 avatar Aug 12 '23 21:08 OpenSource03

Hi, I am very sorry to bother you, but in the Version @mavencentral 0.9.1 this issue still persists (which is interesting because the Github Version 0.9.1 does have that fixed. But when trying to build/install the latest v0.9.1 from github locally I run into a problem with the gpg signing which I havent yet figured yet (I use Windows). Do you have any tips for me? Thanks a lot!

WernerWertitsch avatar Feb 14 '24 17:02 WernerWertitsch