data-client icon indicating copy to clipboard operation
data-client copied to clipboard

fix: Incoming entities should always be processed if existing fails validation

Open ntucker opened this issue 2 years ago • 1 comments

Motivation

This can happen with partial responses - requiring a merge even with 'newer' version

Solution

ntucker avatar Jun 22 '22 23:06 ntucker

Codecov Report

Merging #2055 (d06bc81) into master (6524d3e) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2055   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         102      102           
  Lines        1918     1919    +1     
  Branches      404      405    +1     
=======================================
+ Hits         1889     1890    +1     
  Misses         13       13           
  Partials       16       16           
Impacted Files Coverage Δ
packages/normalizr/src/entities/Entity.ts 98.49% <100.00%> (+0.01%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov-commenter avatar Jun 22 '22 23:06 codecov-commenter

See how this interfaces with #1403 before implementation

ntucker avatar Dec 06 '22 18:12 ntucker

Abandoning in favor of https://resthooks.io/rest/api/schema.Entity#shouldReorder

ntucker avatar Feb 25 '23 03:02 ntucker