reactpy icon indicating copy to clipboard operation
reactpy copied to clipboard

Check for changelog changes

Open rmorshea opened this issue 3 years ago • 1 comments
trafficstars

Current Situation

We tried to check changelog changes in the past, but the GitHub action we used didn't seem to work.

Proposed Actions

I found a working example that we could use as a reference.

rmorshea avatar Jul 13 '22 04:07 rmorshea

I think doing "skip changelog" via labels is inherently flawed.

We really shouldn't give all GitHub users the ability to edit issue labels. The alternative is having project managers (yourself and I) manually manage all "skip changelog" labels for all future PRs. But this could get very tedious as this project grows in size.

This can really only properly be done by validating whether a user has typed "skip changelog" in the PR comments. Which is 100% possible with GitHub's public API, but requires us to create a custom workflow.

Archmonger avatar Jul 16 '22 09:07 Archmonger