reaction icon indicating copy to clipboard operation
reaction copied to clipboard

Move to Node 18

Open brent-hoover opened this issue 4 years ago • 7 comments

Node 18 is LTS. Let's try to get on top of this. Hopefully not many breaking changes if any.

brent-hoover avatar Dec 17 '21 11:12 brent-hoover

So because of this change with the way JSON files are imported in Node 16, every package plus Reaction itself is going to need to be updated in a way that is backwards compatible. Not a lot of programming work, but a fair amount of busy work.

That is not necessarily the only change that needs to be made, but the first one I have identified

brent-hoover avatar Mar 02 '22 00:03 brent-hoover

@zenweasel

So because of this change with the way JSON files ...

This currently prevents me to use @reactioncommerce/api-core with Node 16 in a fresh project. I still need to fallback to Node 14. I would really like to have this issue resolved and could offer my support, if required.

setaman avatar Mar 07 '22 12:03 setaman

We may want to look at just jumping to Node 18 since that just became LTS

brent-hoover avatar Oct 31 '22 01:10 brent-hoover

That would be great. Since nothing works on Macbooks with M1.

alexmukho avatar Nov 26 '22 19:11 alexmukho

Changing this to Node 18, since going to 16 only buys us 5 more months

brent-hoover avatar Dec 02 '22 01:12 brent-hoover

any update on this?

eshwaruppala avatar Mar 10 '23 12:03 eshwaruppala

There's a pr on all of the repos that's just waiting for review

brent-hoover avatar Mar 10 '23 15:03 brent-hoover