reaction-component-library icon indicating copy to clipboard operation
reaction-component-library copied to clipboard

Autofilling the address form does not autofill the region

Open spencern opened this issue 6 years ago • 4 comments

Type: minor

Describe the bug Autofilling the address form does not autofill the region

To Reproduce Steps to reproduce the behavior:

  1. Go to the Address Form component in the component library
  2. Scroll down to an example which dynamically loads a set of countries and regions dynamically
  3. Start to enter an address you have saved in your browser such that it will autofill
  4. See that the region is not autofilled

Expected behavior The Region should be autofilled even if the set of regions are dynamically loaded

Screenshots image

spencern avatar Sep 21 '18 00:09 spencern

Most likely this is an issue with react-select, but could also be that we're not tagging the region field properly for autofill to know what it is.

aldeed avatar Sep 21 '18 00:09 aldeed

I don't see this as a blocker, but we should figure it out at some point because it's pretty annoying

spencern avatar Sep 21 '18 05:09 spencern

After trying a few things and doing some research I beleive this might be coming from react-select. react-select uses a hidden HTML <input /> to capture the actual value and it seems that some browser autofills can't see that input, looks like react-select has an open PR that may address this issue but they're a little out of date.

nnnnat avatar Sep 26 '18 15:09 nnnnat

Moving this to the icebox as it's low priority. It looks like react-select may be abandoned at this point based on the amount of time that https://github.com/JedWatson/react-select/pull/2174 and https://github.com/JedWatson/react-select/pull/2395 have been open.

Open to other ideas for how to resolve this issue

spencern avatar Oct 02 '18 04:10 spencern