reaction-component-library icon indicating copy to clipboard operation
reaction-component-library copied to clipboard

QuantityInput: Rewrite QuantityInput to not use MUI components

Open nnnnat opened this issue 6 years ago • 4 comments

Type: major

Describe the bug The QuantityInput was ported to the component library from the storefront and is built with MUI components. We'd like to rewrite this component to remove the MUI dependence, either by creating a new component or by adding a similar input addornments feature to our current TextInput component.

nnnnat avatar Jul 24 '18 13:07 nnnnat

Pulling this in to sprint because there are JSS styling problems in production build trying to pull this component into the starter kit app.

aldeed avatar Jul 24 '18 19:07 aldeed

@mikemurray do you know roughly how large this issue is?

spencern avatar Oct 02 '18 17:10 spencern

I just found out that QuantityInput was the cause of some weird CSS glitches happening only in production on a client's project. Seems to match @aldeed's description. We were trying to use this component on the Reaction Operator UI. Guess we'll hold off for now.

loan-laux avatar Jul 29 '19 18:07 loan-laux

@loan-laux Interesting, I thought that issue went away, though I don't know if we ever figured out why QuantityInput was causing it.

aldeed avatar Jul 30 '19 20:07 aldeed