react-tags icon indicating copy to clipboard operation
react-tags copied to clipboard

Should pass-through inline styles and className attribute

Open geyang opened this issue 7 years ago • 4 comments

The way this library handles styling atm is quite backwards: https://github.com/prakhar1989/react-tags#styling

A more appropriate way is to pass through inline style tag for the top component plus the className attribute.

The expected pattern to use this with style-components is as follows:

import styled from "styled-components";
import {WithContext as TagInput} from "react-tags";

const StyledTagInput = styled(TagInput)`
     display: flex;
     flex-direction: row;
`

geyang avatar Jul 17 '18 19:07 geyang

@episodeyang would you like to give a pr for this ?

ad1992 avatar Jul 18 '18 18:07 ad1992

hi Aakansha, I don’t have time at the moment. A quick look at the styled components documentation should help. It is the defacto standard for react styling nowadays.

On Wed, Jul 18, 2018 at 11:02 AM Aakansha Doshi [email protected] wrote:

@episodeyang https://github.com/episodeyang would you like to give a pr for this ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prakhar1989/react-tags/issues/372#issuecomment-406021676, or mute the thread https://github.com/notifications/unsubscribe-auth/AAme2saO9QIr_I1IYrRbZXg2csVdHF-Hks5uH3grgaJpZM4VTdXc .

geyang avatar Jul 18 '18 18:07 geyang

@episodeyang thank you for the suggestion to use style-components. I am a little buzy so might not be able to pick this up immediately but will try to push soon for sure.

ad1992 avatar Jul 21 '18 07:07 ad1992

Thanks!

On Sat, Jul 21, 2018 at 12:36 AM Aakansha Doshi [email protected] wrote:

@episodeyang https://github.com/episodeyang thank you for the suggestion to use style-components. I am a little buzy so might not be able to pick this up immediately but will try to push soon for sure.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/prakhar1989/react-tags/issues/372#issuecomment-406777881, or mute the thread https://github.com/notifications/unsubscribe-auth/AAme2p58kDBpi9h6EV7XRfOs8blJyfikks5uItnpgaJpZM4VTdXc .

geyang avatar Jul 21 '18 17:07 geyang