react-big-schedule
react-big-schedule copied to clipboard
react-scheduler
Request for Assistance in Converting Project to functional based totally.
I have been working on my project using a different architecture, but after considering the benefits of functional programming, I have decided to switch to a functional-based approach. This transition will not only align with industry standards but also enhance the maintainability and scalability of my project.
I understand that functional programming promotes immutability, pure functions, and declarative code, which can lead to more predictable and easier-to-test applications. By embracing these principles, I believe my project will become more robust and efficient.
However, I am relatively new to functional programming and would greatly appreciate your guidance and expertise in refactoring my codebase. I am confident that with your assistance, I will be able to successfully migrate my project to a functional-based architecture.
I have already done some initial research and identified areas in my project that can benefit from functional transformations. By adopting higher-order functions, leveraging immutable data structures, and embracing functional composition, I hope to optimize the performance and readability of my code.
Once again, I want to express my gratitude for your willingness to support me in this endeavor. Your expertise and guidance will undoubtedly contribute to the success of my project. Thank you for your assistance and I look forward to working together on this functional conversion.
Hello @ansulagrawal ,
I can help. I suggest to split the codebase on tasks for better organization.
I can start with HeaderView.jsx, it is small component and do not have drag and drop related code.
Hello @ansulagrawal ,
I can help. I suggest to split the codebase on tasks for better organization.
Hello @DamyanBG thank you for showing intrest. For now you can fork the repo and start working on it.
Once we think you are good to go we will add you to colabrators.
Thanks once again.
@ansulagrawal I will start it these days. Can you tell me is that repo converted as package? I was not able to find it in npm...
https://www.npmjs.com/package/react-big-schedule
@DamyanBG here is the link for the npm package
https://www.npmjs.com/package/react-big-schedule
@DamyanBG here is the link for the npm package
Thank you!
Hello @ansulagrawal ,
I made the first PR. I refactored the class component HeaderView to functional component - #73
I have few suggestions:
- please, create me task for every component which I will refactor for better tracking of the progress
- I think there are few things which can be fixed in the logic of that component
- I think it is good idea to add Prettier config file
This is from me for now. Maybe I will have more ideas these days.
Hello @DamyanBG , Yes I was also thinking for the same. You can procced with what all you want. Nice suggestion by the way thanks.
@ansulagrawal thank you for inviting me in the project! Me and my team are developing big React applications and we was looking for good resource scheduler library, but non of the existing libraries are good enough to rely on them. I will try to help to maintain this new library and even enhance the functionality.
So do you want me to split the work on smaller tasks and to add labels good-first-issue and help-needed? Usually there are a lot people who are looking for projects to contribute. If we split the work on smaller issues, then I think it will be better.
Hello @ansulagrawal and @JitendraSoni1234 ,
What is that non organization here? I refactored HeaderView component from class to functional. I can see that @JitendraSoni1234 committed some hotfix directly to the master branch :D and returned the previous class component. Isn't better to provide information about that hotfix and to see the problems behind it, to fix it and continue on the functional component. With organization like this be sure that this repo will have no feature.
@DamyanBG the code reverted back was done due to the header view was not working as expected as the date used to show invalid date.
Sorry for not informing you, but due to urgent requirement we did that.
Okay, give me the code example which broke the functional component and I will take a look.
Here is the link: https://codesandbox.io/s/suspicious-cdn-fzj624?file=/src/App.js:220-238.
check for day format its not working fine but for week its working fine
Okay, thank you for the provided information. I had a little mistake when refactored the code. I made a PR with working code. You can check.
Hello Team, we have decided to stop converting to functional based totally as its just of time waste and no one is free to do so. If any one want to do he/she can do it and raise the pr. But internal team won't be spending time on this anymore.
- Regards React Big Schedule Team.