stack icon indicating copy to clipboard operation
stack copied to clipboard

Disable bottom hit slop of iOS back button

Open Manduro opened this issue 4 years ago • 3 comments

This fixes a bug where the hit area of the back button overlaps a few pixels of content below the header, making it impossible to interact with that content.

Manduro avatar Jul 25 '19 19:07 Manduro

Does it work fine on Android? As from the code I see it's bottom: 8,

enagorny avatar Aug 02 '19 10:08 enagorny

On Android it works fine, the hit slop does not go outside of the header bar.

This shows the issue on iOS: back-button

This PR is not adding extra hitSlop. There is a default hitSlop for iOS here: https://github.com/react-navigation/stack/blob/master/src/views/TouchableItem.tsx#L64 I merely took the default and set the bottom to zero.

Manduro avatar Oct 16 '19 14:10 Manduro

Thanks for the clarification. Can we remove the extra hitSlop from TouchableItem instead? I think it's not needed and it's a bit confusing to have it by default.

satya164 avatar Oct 16 '19 15:10 satya164