react-navigation icon indicating copy to clipboard operation
react-navigation copied to clipboard

feat: add hideKeyboardOnSwipe prop from react-native-screens to native-stack

Open gabrieldonadel opened this issue 3 years ago β€’ 4 comments

Motivation

This PR adds the missing hideKeyboardOnSwipe prop from react-native-screens to react-navigation/native-stack.

This is prop is essential if we need to hide the keyboard on the swipe gesture and it is set to false by default since it is not the default native behavior.

In order to use this prop thought I had to upgrade react-native-screens to 3.15.0

Test plan

All tests passed.

  • yarn typescript
  • yarn lint
  • yarn test
  • yarn example start runs

gabrieldonadel avatar Aug 10 '22 18:08 gabrieldonadel

Hey gabrieldonadel! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

github-actions[bot] avatar Aug 10 '22 18:08 github-actions[bot]

Deploy Preview for react-navigation-example ready!

Name Link
Latest commit 904be83a99c85db9b6c9ba6e2deca762724537a6
Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/633ca71a8636a00009831445
Deploy Preview https://deploy-preview-10750--react-navigation-example.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 10 '22 18:08 netlify[bot]

Codecov Report

Merging #10750 (3bfbe66) into main (25803a4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #10750   +/-   ##
=======================================
  Coverage   74.86%   74.86%           
=======================================
  Files         167      167           
  Lines        5125     5125           
  Branches     1983     1983           
=======================================
  Hits         3837     3837           
  Misses       1250     1250           
  Partials       38       38           
Impacted Files Coverage Ξ”
.../native-stack/src/views/NativeStackView.native.tsx 66.98% <ΓΈ> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 16 '22 14:08 codecov-commenter

@kacperkapusciak could you take another look at this please?

gabrieldonadel avatar Oct 04 '22 21:10 gabrieldonadel

@gabrieldonadel I hesitate so badly to add this prop as the behavior this prop introduces is janky and far from perfect

https://user-images.githubusercontent.com/39658211/194919503-01a72517-47c9-477a-ad36-c1e8d57f98ff.mp4

on the other hand keyboard animation in the JS stack keyboardHandlingEnabled works smoothly:

https://user-images.githubusercontent.com/39658211/194919866-a373fdd0-72c9-48b7-9f9e-f808d4f7094b.mp4

kacperkapusciak avatar Oct 10 '22 17:10 kacperkapusciak

Hello, the PR got closed automatically due to some changes in the main branch. Would you be able to send a new PR? Thank you.

satya164 avatar Nov 27 '22 21:11 satya164

Hey! This issue is closed and isn't watched by the core team. You are welcome to discuss the issue with others in this thread, but if you think this issue is still valid and needs to be tracked, please open a new issue with a repro.

github-actions[bot] avatar Nov 27 '22 21:11 github-actions[bot]