native icon indicating copy to clipboard operation
native copied to clipboard

Initial nav state is always asynchronous (for Linking.getInitialUrl)

Open Minishlink opened this issue 6 years ago • 10 comments

Follow-up of https://github.com/react-navigation/react-navigation/pull/4213

Minishlink avatar Feb 09 '19 15:02 Minishlink

I like this change, and it seems well implemented. In most cases I think things will behave the same.

But it may break things for people who expect the previous behavior of initializing the navigation state and doing another action for the URL. So I am cautious about moving forward.

cc @brentvatne, should we defer stuff like this to v4? This nuance is undocumented, so we might get away with a v3 release.

ericvicenti avatar Mar 29 '19 22:03 ericvicenti

Thanks @ericvicenti

Minishlink avatar Apr 03 '19 08:04 Minishlink

@Minishlink - could you possibly write up some documentation explaining this behavior? once that's ready we can decide whether we can land it in v3 as-is, put it behind a feature flag, or defer until v4

brentvatne avatar Apr 12 '19 15:04 brentvatne

Hey all, looks like this fixes some behavior I'm seeing. Any idea when this might be released? Thanks

alexpyoung avatar Aug 12 '19 21:08 alexpyoung

Any idea when this will be released? Thank you for this PR.

AfrazHussain avatar Nov 15 '19 22:11 AfrazHussain

Also waiting for this PR to fix the issue described on https://github.com/react-navigation/react-navigation/issues/5844

iujisato avatar Dec 04 '19 01:12 iujisato

Has this issue been fixed already? Should I just update react navigation? Thanks!

dccabao avatar Dec 09 '19 03:12 dccabao

Hey, is this fixed yet ?

Epiczzor avatar Jan 29 '20 18:01 Epiczzor

Can this PR be updated to resolve the conflict and merge ?

t49tran avatar Feb 17 '20 04:02 t49tran

Unless there is a core contributor who wants to merge this, I probably won't update it until I upgrade one of my projects to RNav 5 (two to four weeks), feel free to do another one :)

Minishlink avatar Feb 19 '20 11:02 Minishlink