react-native-callkeep
react-native-callkeep copied to clipboard
react-native-webrtc
Package androidx.localbroadcastmanager.content does not exist
Bug report
-
[ ] I've checked the example to reproduce the issue.
-
Reproduced on:
-
[x] Android
-
[ ] iOS
Description
Package androidx.localbroadcastmanager.content does not exist error in VoiceConnection.java:27.
Steps to Reproduce
Install latest Callkeep and try to build project for Android with the latest React Native.
Versions
- Callkeep: 4.3.3
- React Native: 0.69.1
Logs
/node_modules/react-native-callkeep/android/src/main/java/io/wazo/callkeep/VoiceConnection.java:27: error: package androidx.localbroadcastmanager.content does not exist
import androidx.localbroadcastmanager.content.LocalBroadcastManager;
^
Hey, i have been facing a similar issue and i found out that google has split the v4 library into multiple packages :
Note: Prior to Support Library revision 24.2.0, there was a single v4 support library. That library was divided into multiple modules to improve efficiency. For backwards compatibility, if you list support-v4 in your Gradle script, your app will include all of the v4 modules. However, to reduce app size, we recommend that you just list the specific modules your app needs.
hence we need to add explicitly mention androidx.localbroadcastmanager:localbroadcastmanager:1.1.0 dependency.
i wanted to create PR for the same but dont have push rights, if someone can help me with that, it will be great.
Till then i have created a fork with fix here - https://github.com/ohheyitskartik/react-native-callkeep-with-broadcast-manager
Hello @ohheyitskartik, everyone have the right to open a PR. I don't understand why you said that. Do you have a message for this issue? Sylvain
@sboily, my bad i just cloned the repo & didn't fork it hence i was not able to select my branch for a PR, i have just raised one #596
@alexanderoskin that work, open node_modules/react-native-callkeep/android/build.graldew add :
implementation "androidx.localbroadcastmanager:localbroadcastmanager:1.1.0"
run npx patch-package react-native-callkeep
how can I fix this error so that I don't have to modify the plugin files every time?
Facing the same issue
I have to update build.gradle at following path.
/node_modules/react-native-callkeep/android/build.gradle
I have attached gradle file as build.txt due to github security.
"react-native": "0.70.0", "react-native-callkeep": "^4.3.3",
same issue
*Update
Fix merged to master but not released yet
@manuquentin, can you update the package on https://www.npmjs.com/package/react-native-callkeep??
package need to be released new version, although it should be automated
Until a new version is released you can change in your package.json file
"react-native-callkeep": "4.3.3",
to
"react-native-callkeep": "git+https://github.com/react-native-webrtc/react-native-callkeep#4b1fa98a685f6502d151875138b7c81baf1ec680",
to get the fix right away.
is this released yet? and if it's not is there any workarounds to use this fix?
