react-native-web-webview icon indicating copy to clipboard operation
react-native-web-webview copied to clipboard

Update index.js

Open claudiaTonak opened this issue 2 years ago • 2 comments

supress scrollbar if scrollEnabled is false

claudiaTonak avatar Jun 20 '22 13:06 claudiaTonak

I did

Von: Louis Lagrange @.> Gesendet: Dienstag, 21. Juni 2022 16:32 An: react-native-web-community/react-native-web-webview @.> Cc: Tonak, Claudia @.>; Author @.> Betreff: Re: [react-native-web-community/react-native-web-webview] Update index.js (PR #67)

@Minishlink commented on this pull request.


In src/index.jshttps://github.com/react-native-web-community/react-native-web-webview/pull/67#discussion_r902699357:

@@ -129,6 +129,7 @@ export class WebView extends Component {

   allowpaymentrequest: 'true',

   frameBorder: '0',

   seamless: true,
  •  scrollEnabled?'yes':'no',
    

I doubt you tested this code

— Reply to this email directly, view it on GitHubhttps://github.com/react-native-web-community/react-native-web-webview/pull/67#pullrequestreview-1013719968, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXIXQNUQ2CN2JTQCXXD2NIDVQHG7PANCNFSM5ZI6MFCQ. You are receiving this because you authored the thread.Message ID: @.@.>>

claudiaTonak avatar Jun 21 '22 14:06 claudiaTonak

What’s wrong with my changes? Works like a charm here. I tried to eleminate the scrollbars of an iframe. An iframe needs a

claudiaTonak avatar Jun 23 '22 11:06 claudiaTonak