create-xp-app icon indicating copy to clipboard operation
create-xp-app copied to clipboard

Published 20 hours ago • verified publisher icon react-native-training

Create dev script for live reloading of web and ios

Open nikolasleblanc opened this issue 7 years ago • 6 comments

Enables dev script which:

  • launches webpack-dev-server with react-hot-loader
  • launches ios emulator from cli

Eliminates need to run your own server for testing web and eliminates need to open xcode.

nikolasleblanc avatar Jun 09 '17 15:06 nikolasleblanc

To be honest I just put it there based on what my reference had had. Not partial to it.

On Sun, Jun 11, 2017, 1:36 AM Binoy, [email protected] wrote:

@binoy14 commented on this pull request.

In src/webpack.config.ts https://github.com/react-native-training/create-xp-app/pull/8#discussion_r121272545 :

 output: {

     filename: "bundle.js",

  •    path: __dirname + "/dist"

  •    path: __dirname + "/dist",

  •    publicPath: "/dist"

@nikolasleblanc https://github.com/nikolasleblanc Shouldn't the public path be / ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/react-native-training/create-xp-app/pull/8#pullrequestreview-43311860, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2terb3yLOz6fsGf-gIHHmUEMCXCjYhks5sC3zzgaJpZM4N1hGT .

nikolasleblanc avatar Jun 11 '17 05:06 nikolasleblanc

@nikolasleblanc Thanks for the PR, I was just starting to work on this and saw this PR

binoy14 avatar Jun 11 '17 05:06 binoy14

Awesome I can fix that up for you tomorrow morning if you like, applying your recommendations. And sure, I'm up for that change about web-watch - we should probably add start:iOS to rn-watch too. Sound ok?

On Sun, Jun 11, 2017, 1:38 AM Binoy, [email protected] wrote:

@nikolasleblanc https://github.com/nikolasleblanc Thanks for the PR, I was just starting to work on this and saw this PR

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/react-native-training/create-xp-app/pull/8#issuecomment-307608099, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2tejgmP8fOEkt-na5zW1BLKzf0NKyJks5sC31pgaJpZM4N1hGT .

nikolasleblanc avatar Jun 11 '17 05:06 nikolasleblanc

I would say add rn-watch to start:ios and start:android so it's not always defaulting to ios. Crucial if someone is using this from a windows machine

binoy14 avatar Jun 11 '17 05:06 binoy14

@nikolasleblanc thanks so much for the PR, it looks great :)

@binoy14 @nikolasleblanc is this ok to go ahead and merge, or will there be changes?

dabit3 avatar Jun 15 '17 08:06 dabit3

@dabit3 I this this is good. I am gonna make some changes to webpack to add live reloading and I can address the comments than. Maybe don't release this just yet?

binoy14 avatar Jun 17 '17 16:06 binoy14