picker icon indicating copy to clipboard operation
picker copied to clipboard

remove unneccessaries from pch to reduce size and fix storage quota issues in build

Open burtonrodman opened this issue 4 years ago • 3 comments

significant reduction in size of PCH by removing unnecessary includes

burtonrodman avatar Apr 27 '21 18:04 burtonrodman

Lgtm assuming this still builds after removal.

NickGerleman avatar May 12 '21 21:05 NickGerleman

this will reduce the pch size (known to be large) at the expense of slower builds (recompiling the same headers everywhere they are used), which for xaml headers can be significant.

asklar avatar May 19 '21 15:05 asklar

agreed. but if it doesn’t build at all because it generates a gig of pch and exceeds the build agent storage quota, then that perf gain is a detriment

burtonrodman avatar May 19 '21 16:05 burtonrodman