google-signin icon indicating copy to clipboard operation
google-signin copied to clipboard

🚧🚧 Maintenance notice 🚧🚧

Open vonovak opened this issue 3 years ago • 18 comments

Hello, I'm putting this up to explain what you can expect from me as a maintainer:

The module is a wrapper around the google sign in SDK, and is, I believe, in a fairly stable state. It supports expo as well. Problems encountered when using the module are often configuration issues, or issues that do not pertain to this module but the underlying native SDK.

The one thing missing now is not having support for the new architecture - you can sponsor me if you want to see this move forward 🙂 .

I personally am not working on a project that would use this package and I do not have time to give it regular maintenance. I will not be responding to issues very often but I will be available to review and merge PRs.

If you need to add some missing features or get help of any kind, you can get in touch with me via https://react-native-training.eu - as a paid service.

If you want to get involved in the maintenance of this module, let me know and I'll invite you to the repo! Ideally, I'd like you to have some track record in OSS before I do that - you can easily contribute from a fork too, in order to build that track record. :)

Thank you!

vonovak avatar Jan 06 '21 13:01 vonovak

Hi there! can I ask something I`m currently using this module. but then I encounter an error in configuration it says RN GoogleSignin native module is not correctly linked. does this maintenance cause the issue?

screenshot

err

My react native version is Screen Shot 2021-01-07 at 10 36 03 AM

chromneil-pedeglorio avatar Jan 07 '21 02:01 chromneil-pedeglorio

@chromneil-pedeglorio thanks for asking, please read the error message and act accordingly, this is a problem with your setup. Thanks

vonovak avatar Jan 07 '21 09:01 vonovak

Hi there! can I ask something I`m currently using this module. but then I encounter an error in configuration it says RN GoogleSignin native module is not correctly linked. does this maintenance cause the issue?

screenshot err

My react native version is Screen Shot 2021-01-07 at 10 36 03 AM

is your problem got fixed.

ashishonmobile avatar Feb 12 '21 23:02 ashishonmobile

Hi there! can I ask something I`m currently using this module. but then I encounter an error in configuration it says RN GoogleSignin native module is not correctly linked. does this maintenance cause the issue? screenshot err My react native version is Screen Shot 2021-01-07 at 10 36 03 AM

is your problem got fixed.

Hi, there @ashishonmobile apparently my problem is fixed based on what @vonovak said my setup cause the problem.. so I just focused on reproducing the bug and like a miracle, it worked correctly.

chromneil-pedeglorio avatar Feb 15 '21 05:02 chromneil-pedeglorio

I though do not have any issue setting this module up with my project, still I must say, am not happy the the project will be lacking maintainence as stated by the proj. owner

gems-inc avatar Mar 09 '21 16:03 gems-inc

@Gems-gr I have updated the original comment to make one thing clear:

If you want to get involved in the maintenance of this module, let me know and I'll invite you to the repo!

so - if you're not happy with the lack of maintenance from me, and want to get involved in the maintenance, please let me know! It's not like the project is just sitting here out of reach, it's open source and anyone can contribute! 🙂

vonovak avatar Mar 10 '21 00:03 vonovak

Hi there! can I ask something I`m currently using this module. but then I encounter an error in configuration it says RN GoogleSignin native module is not correctly linked. does this maintenance cause the issue? screenshot err My react native version is Screen Shot 2021-01-07 at 10 36 03 AM

is your problem got fixed.

Hi, there @ashishonmobile apparently my problem is fixed based on what @vonovak said my setup cause the problem.. so I just focused on reproducing the bug and like a miracle, it worked correctly.

How did you fix the issue please ?

inas20 avatar Apr 11 '21 11:04 inas20

I'd like to help you a little bit. Can I join the repo?

jimanjang avatar Apr 20 '21 02:04 jimanjang

Hi there! can I ask something I`m currently using this module. but then I encounter an error in configuration it says RN GoogleSignin native module is not correctly linked. does this maintenance cause the issue? screenshot err My react native version is Screen Shot 2021-01-07 at 10 36 03 AM

is your problem got fixed.

Hi, there @ashishonmobile apparently my problem is fixed based on what @vonovak said my setup cause the problem.. so I just focused on reproducing the bug and like a miracle, it worked correctly.

How did you fix the issue please ?

Hi @inas20,

Check your manual setup eventhough. I`m using react-native version: 0.61.5 and using a package from this version must be auto-link i think this is not applicable on all packaged, and so i fixed my issue just checking may manual setup carefully and manipulating the versions of the google-signin. Try to use this version

"dependencies": { "@react-native-community/google-signin": "^5.0.0" }

chromneil-pedeglorio avatar May 14 '21 01:05 chromneil-pedeglorio

Hi @vonovak, I want to support this module by writing the Expo Config plugin for it. So, what do you think?

giautm avatar Feb 24 '22 09:02 giautm

Hi, sounds great! Please feel free to open a pull request for it 🙌. Thank you! 😊

vonovak avatar Feb 24 '22 09:02 vonovak

I no longer use this module in production and I do not have time to give it regular maintenance.

I'm curious: what do you use in production now? Or do you not use React Native or Google Sign-in any more?

kshehata avatar Apr 26 '22 08:04 kshehata

I'm curious: what do you use in production now? Or do you not use React Native or Google Sign-in any more?

I'm just not working on a project that uses google sign in

vonovak avatar Apr 26 '22 14:04 vonovak

For the record: Expo released SDK 46 a few days ago, which removes (it was deprecated in SDK 45) the expo-google-sign-in library, in favor of this library. Thus, we'll see an increment of bug reports, issues, PRs, etc.

BrodaNoel avatar Aug 03 '22 21:08 BrodaNoel

Thanks for the update @BrodaNoel.

For anyone new to this like me, here is the Expo documentation on this. It states that the Google Provider from Expo's AuthSession package is the new way but that this one (react-native-google-signin) can also be used. I'm diving in right now and I'll update this if I find anything new. First day in Expo/React Native, here goes nothing.

surfingdoggo avatar Aug 20 '22 02:08 surfingdoggo

Thanks for the update @BrodaNoel.

For anyone new to this like me, here is the Expo documentation on this. It states that the Google Provider from Expo's AuthSession package is the new way but that this one (react-native-google-signin) can also be used. I'm diving in right now and I'll update this if I find anything new. First day in Expo/React Native, here goes nothing.

Any luck?

wordisthebird avatar Aug 26 '22 10:08 wordisthebird

People: I have this package installed in Expo SDK 46 and it's working perfectly. Android and iOS. So... go for it!

BrodaNoel avatar Aug 26 '22 13:08 BrodaNoel

@BrodaNoel RN GoogleSignin native module is not correctly linked. am facing this issue ... can you share the linking step that you went through?

AdnanAshraf-gol avatar Sep 30 '22 07:09 AdnanAshraf-gol

@vonovak I have received an email from google saying "We detected requests to our OAuth 2.0 authorization endpoint from one or more of your OAuth client IDs within an embedded webview context". as I used old version 5.0.0 I decided to upgrade to the newest one hoping that after 7.0.0 this library stopped using webview but I dont see any changes in behavior. does it still use webiew to open login page?

mijastrzebski avatar Nov 18 '22 10:11 mijastrzebski

I am facing [Error: DEVELOPER_ERROR] Error Code 10 ? what is mean ?

prem-tcpl avatar Dec 22 '22 03:12 prem-tcpl

will definitely contribute

stephanelpaul avatar Jan 05 '23 00:01 stephanelpaul

Guys please be respectful of the creator! After going through this thread, all I could see was selfishness of people.

They are getting paid at their job and here they are expecting the maintainers to do it for free. Have some respect for the OSS maintainers.

The author had to hide so many comments, which shows people's negligence.

Thanks @vonovak for your contribution. I understand how frustrating it can be to be maintainer without getting any support.

I am not using the library right now, still I'll sponsor to support you and keep you motivated.

ShivamJoker avatar Feb 17 '23 10:02 ShivamJoker

This might help https://www.youtube.com/watch?v=VH1YBcVmM-M

BraveEvidence avatar Feb 28 '23 13:02 BraveEvidence

Hello everyone, quick update: the New Architecture as well as the new One-Tap sign in is available in the paid version of the package, see instructions here: https://github.com/react-native-google-signin/google-signin#project-setup-and-initialization

Thank you! 🙂

vonovak avatar Jul 25 '23 08:07 vonovak