document-picker icon indicating copy to clipboard operation
document-picker copied to clipboard

mac os support

Open danilaplee opened this issue 2 years ago • 11 comments

Screenshot 2022-12-21 at 16 28 25 Screenshot 2022-12-21 at 16 51 30

Summary

OSX support is critical for my product

Test Plan

tested on OSX

What's required for testing (prerequisites)?

use base functionality

What are the steps to reproduce (after prerequisites)?

use base functionality

Compatibility

OS Implemented
iOS
macOS
Android

Checklist

  • [ ] I have tested this on a device and a simulator
  • [x] I added the documentation in README.md
  • [x] I updated the typed files (TS and Flow)

danilaplee avatar Dec 21 '22 12:12 danilaplee

can anyone test this one in ios, because i currently don't have a stable ios build of my app

I have tested only on mac os

danilaplee avatar Dec 21 '22 12:12 danilaplee

I managed to test it on the iOS emulator and seems to work. See screenshots attached - let me know if more info needed

chriscarex avatar Dec 30 '22 10:12 chriscarex

@chriscarex thank you so much, next I'am gonna add support for the web with a new merge request

danilaplee avatar Dec 30 '22 11:12 danilaplee

hello and thanks for the PR I have a lot on my plate right now and am taking a vacation soon, I think I'll be able to take a proper look at the end of the month, thank you

vonovak avatar Jan 02 '23 17:01 vonovak

@vonovak cool thanks

danilaplee avatar Jan 02 '23 21:01 danilaplee

@vonovak if anything worries you about my pr please write the changes i should make and dont close the pr, I will make the changes because i'am building my open source project on top of your stuff and i would like it to be used properly as you intended and i'am open to code style changes for sure, especially linting

danilaplee avatar Jan 11 '23 01:01 danilaplee

Hello and thank you for your PR!

Sorry for taking so long to get back to you.

First, how can I test this in the example app? Does this use Mac catalyst? Is it intended for react-native-macos?

Thank you

vonovak avatar Mar 13 '23 23:03 vonovak

I am actively developing a react-native-macos application and would be willing to be a test dummy for this. Can we get the PR merged up to latest and I can give it a go in my project?

keenan-v1 avatar May 27 '23 22:05 keenan-v1

Hi, Now, does this package support mac os ? i am trying but gives me error..

atiqulislamwb avatar Sep 04 '23 07:09 atiqulislamwb

I also have a use case for this in my react-native-macos app. Any chance we can get this merged?

danishshaik avatar May 10 '24 05:05 danishshaik

Might be good to recheck, but it sounds good

Elyx0 avatar Oct 11 '24 03:10 Elyx0

Hello, I'm closing this because I open-sourced the new rewritten module which was previously private.

It comes with completely rewritten iOS internals with Swift, and macOS support should be added with Swift too. Happy to review a new PR that does that.

Thank you!

vonovak avatar Jan 22 '25 09:01 vonovak