Add support for the new architecture

[capezzbr]

Was wondering if you had plans to add support for the new Fabric renderer

[vonovak]

Hello, Thanks for asking. Yes, the new renderer will be supported but I cannot give a specific time line. I think I want to wait for RN 0.70 to be stable before I start this. If anyone wants to support this, sponsorships are open :) Thank you 🙂

[capezzbr]

@vonovak thanks for following up! I know it's hard to provide a timeline, but it believe this would help folks relying on this library that want to enable Fabric 🙇

[tom-sherman]

Will this work also include turbomodule support? If so, can we change the issue title?

[BrunoVillanova]

Hey guys,

I can help with that. What is the current status of this issue? Has anyone already started?

[alfonsocj]

Hey, I just started today on supporting Fabric for iOS.

[BrunoVillanova]

Awesome! Please tell me if you need some help. ☺️ On 2 Sep 2022 20:46 -0300, Alfonso Curbelo @.***>, wrote:

Hey, I just started today on supporting Fabric for iOS. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

[capezzbr]

PR in review https://github.com/react-native-datetimepicker/datetimepicker/pull/657

[vonovak]

reopening since android is still pending

[alfonsocj]

I think the example is the one not compatible. I'll investigate further.

[ShrutiRani7029]

HEY, I HAVE DONE MY PROJECTS ON REACT NATIVE WHERE I INNOVATE AND ADD NEW FEATURES, CAN YOU GIVE ME A CHANCE SO THAT I ADD A NEW ARCHITECTURE?

[EkaterinaMozheiko]

Is there any update about implementing Fabric support for Android?

[HarshaR1642]

Is there any update about implementing Fabric support for Android?

+1

[vonovak]

Hello, the android part of this module does not really render anything in react native, and therefore android will not need to support Fabric because it will never use Fabric. However, we will need to support the new turbomodules. I'm planning to add turbomodules support to another module I maintain and then add the support here. My timeline is that I'll prob start in ~1.5 months. ~~If anyone wants to do that before, please let us know here and go ahead!~~ 👍 @ShrutiRani7029

update: android migration is in progress

[capezzbr]

Also, if you are experiencing an issue building your Android app with the new architecture enabled on RN 0.70, you should add this snippet of code to your react-native.config.js

module.exports = {
  dependencies: {
    ...
    // https://github.com/react-native-community/cli/blob/0e63e750a235062cd9bc43ed6a4a2beb8f14385a/docs/autolinking.md#how-can-i-disable-autolinking-for-new-architecture-fabric-turbomodules
    '@react-native-community/datetimepicker': {
      platforms: {
        android: {
          libraryName: null,
          componentDescriptors: null,
          androidMkPath: null,
          cmakeListsPath: null,
        },
      },
    },
  },

the issue from my understanding is that @react-native-community/datetimepicker doesn't have any Android UI components that needs to be autolinked, but RN CLI does detect what is defined in the module package.json, which are only for iOS. I believe a better workaround would be to created a react-native.config.js in the @react-native-community/datetimepicker, that does the above. ~~I am happy to open a PR with this fix soon~~ I am not sure if we can fix this at the library level, the fix might need to be applied at the app level

[HarshaR1642]

Also, if you are experiencing an issue building your Android app with the new architecture enabled on RN 0.70, you should add this snippet of code to your react-native.config.js

module.exports = {
  dependencies: {
    ...
    // https://github.com/react-native-community/cli/blob/0e63e750a235062cd9bc43ed6a4a2beb8f14385a/docs/autolinking.md#how-can-i-disable-autolinking-for-new-architecture-fabric-turbomodules
    '@react-native-community/datetimepicker': {
      platforms: {
        android: {
          libraryName: null,
          componentDescriptors: null,
          androidMkPath: null,
          cmakeListsPath: null,
        },
      },
    },
  },

the issue from my understanding is that @react-native-community/datetimepicker doesn't have any Android UI components that needs to be autolinked, but RN CLI does detect what is defined in the module package.json, which are only for iOS. I believe a better workaround would be to created a react-native.config.js in the @react-native-community/datetimepicker, that does the above. I am happy to open a PR with this fix soon

Hi @capezzbr I added your temporary fix and tried but it is not working, still facing the same issue with android

[capezzbr]

@HarshaR1642 what exactly is the error you are experiencing

[Josh2941]

DatePicker is not rendering on Android. On iOS Simulator it works fine. I am on RN 0.70.6.

[BraveEvidence]

f interested I have achieved this functionality for new architecture using fabric https://www.youtube.com/watch?v=W3m-8_QuC14&list=PLQhQEGkwKZUrempLnmxjt7ZCZJu1W3p2i&index=4 and https://www.youtube.com/watch?v=38dpw_s2YKE&list=PLQhQEGkwKZUrempLnmxjt7ZCZJu1W3p2i&index=3

[vonovak]

update: the android support is happening here: https://github.com/react-native-datetimepicker/datetimepicker/pull/730

[vonovak]

closed via #730 🎉