datetimepicker icon indicating copy to clipboard operation
datetimepicker copied to clipboard

ViewPropTypes is deprecated

Open billnbell opened this issue 2 years ago • 2 comments

ViewPropTypes is deprecated

use deprecated lib.

billnbell avatar Apr 07 '22 06:04 billnbell

ViewPropTypes support is removed on react-native 0.69.0

glaucopgomes avatar Jul 25 '22 22:07 glaucopgomes

Will this be addressed? If used in Expo SDK 46 this will break the app because of react-native 0.69.4

brantsrasmus avatar Aug 12 '22 09:08 brantsrasmus

Bump Is a patch with deprecated-react-native-prop-types module possible ? Do you guys need a PR ?

I actually started an app with 0.69.4 and this creates an ERROR, not a WARN anymore...

t-leclercq avatar Aug 15 '22 21:08 t-leclercq

Hello and thanks for reporting, The ViewProps that this lib is using are from here https://github.com/facebook/react-native/blob/e0a71fc7b5cb8c264000147099be5b2575931193/Libraries/Components/View/ViewPropTypes.js#L402

and they still exists. I don't believe the reported issue is present in this lib. Please add a minimum reproduction, otherwise this is not actionable, thank you.

Thank you 🙂

vonovak avatar Aug 20 '22 08:08 vonovak

Will this be addressed? If used in Expo SDK 46 this will break the app because of react-native 0.69.4

I also thought the same. However, I just built a small snack and it works.

However, are ViewPropTypes not used here? Maybe we should update this file?

RRaideRR avatar Sep 01 '22 10:09 RRaideRR

Hello, I don't belive we're using the deprecated package in this lib and so I'm going to close the issue.

vonovak avatar Sep 15 '22 23:09 vonovak

:wave: @billnbell, sorry you're having an issue. This issue is being closed because it does not provide all information required by the issue template. As the issue template explains, we require that you provide a runnable example that reproduces your issue and your environment information. This means you need to provide a code snippet that we can copy-paste into an empty project and see the error ourselves, or provide a git repository with the issue. The reason is that maintainers do not have time to try reproduce bugs themselves. Please try to minimize the superfluous code and focus only on reproducing the bug. Please create a new issue with this and we'll be happy to review it!

github-actions[bot] avatar Sep 15 '22 23:09 github-actions[bot]