upgrade-helper icon indicating copy to clipboard operation
upgrade-helper copied to clipboard

Dark mode

Open pvinis opened this issue 4 years ago • 10 comments

We should add a dark mode, so we don't get blind.

pvinis avatar Sep 05 '19 09:09 pvinis

I'm spending some time on this, what I got so far:

Upgrade-Helper with Dark Mode

Upgrade-Helper with Dark Mode and the from dropdown version opened

I would really appreciate feedback on the colors, I'm basically just trying stuff until it looks good, still have quite some stuff to do though.

/cc @pvinis @kelset @KevinHu2014 @vinnyA3 @iamrestrepo

lucasbento avatar Sep 17 '19 11:09 lucasbento

As a reference, this is how a GitHub PR looks like when using GitHub-Dark:

PR on GitHub with GitHub-Dark

lucasbento avatar Sep 17 '19 11:09 lucasbento

I'd only suggest to improve accessibility (ps. I might have gotten the green color wrong, also need to check the red).

Screenshot 2019-09-17 at 13 13 47

Johan-dutoit avatar Sep 17 '19 12:09 Johan-dutoit

@Johan-dutoit: thanks for the tip!

What tool are you using to check that?

The green color is #6ba978 btw, don't know if that will change much though.

lucasbento avatar Sep 17 '19 12:09 lucasbento

I just used https://webaim.org/resources/contrastchecker/

i.e. https://webaim.org/resources/contrastchecker/?fcolor=FFFFFF&bcolor=6BA978

Johan-dutoit avatar Sep 17 '19 12:09 Johan-dutoit

@Johan-dutoit useful tool! thank you for sharing 😄

vinnyA3 avatar Sep 17 '19 13:09 vinnyA3

@lucasbento Looks awesome! My eyes thank you lol. Kind of sort of tangential, but where are you planning on putting the toggle? I was thinking perhaps it would be nice to put it in the settings dropdown.

vinnyA3 avatar Sep 17 '19 13:09 vinnyA3

@vinnyA3: yeah, I want to put on the settings but still need to look into it.

lucasbento avatar Sep 18 '19 09:09 lucasbento

@lucasbento Wow! It looks Awesome 👍

KevinHu2014 avatar Sep 24 '19 17:09 KevinHu2014

is there any progress on this?

SaeedZhiany avatar Apr 24 '22 10:04 SaeedZhiany

not yet. I might spend some time soon. Until then, I recommend https://darkreader.org/.

pvinis avatar Nov 12 '22 04:11 pvinis