upgrade-helper icon indicating copy to clipboard operation
upgrade-helper copied to clipboard

Published 20 hours ago • verified publisher icon react-native-community

Line numbers are copied

Open JohanADT opened this issue 5 years ago • 5 comments

Bug

When I copy code from the upgrade helper and paste it into my editor, the line numbers are also copied.

linenumbers

Info

Safari: 12.1.1 (14607.2.6.1.1) VS Code: 1.36.1 (1.36.1)

JohanADT avatar Jul 19 '19 10:07 JohanADT

This only happens on Safari, on Chrome it works as expected.

This looks like a bug with the library we use but I'm gonna look deeper just to make sure, thanks for filling this issue @JohanADT & @Johan-dutoit! (😜)

lucasbento avatar Jul 19 '19 10:07 lucasbento

@JohanADT Such a great guy for reporting these errors!

Johan-dutoit avatar Jul 19 '19 10:07 Johan-dutoit

Safari is the new Internet Explorer anyone?

mausworks avatar Aug 07 '19 10:08 mausworks

Yea safari is all kinds of broken here. Aug-07-2019 13-34-34 It's also selecting left and right at the same time..

pvinis avatar Aug 07 '19 11:08 pvinis

It seems to related to Chrome and Safari have different behavior when copying texts styled user-select: none .

Here's the reference https://github.com/otakustay/react-diff-view/issues/62 .

KevinHu2014 avatar Aug 13 '19 09:08 KevinHu2014

this is fixed. closing.

pvinis avatar Nov 12 '22 05:11 pvinis

this is fixed. closing.

This is NOT fixed on latest Safari v16.3 @pvinis

Mazztwo avatar Jul 13 '23 17:07 Mazztwo