rn-diff-purge icon indicating copy to clipboard operation
rn-diff-purge copied to clipboard

Missing release tags in this repo cause @react-native-community/cli to not prompt for RN upgrades

Open liamjones opened this issue 3 years ago • 2 comments

Output from react-native start --verbose:

debug Checking for a newer version of React Native
debug Current version: 0.63.4
debug Cached release version: 0.60.0
debug Checking for newer releases on GitHub
                 Welcome to React Native!
                Learn once, write anywhere



To reload the app press "r"
To open developer menu press "d"

debug Latest release: 0.60.0

This happens because the RN CLI checks this repo's tags to discover new RN versions (see https://github.com/react-native-community/cli/blob/5ec3fcf3a623b5a9faef050b72eab3778f241761/packages/cli/src/tools/releaseChecker/getLatestRelease.ts#L74) and no release since v0.60.0 has been tagged in this repo.

Can we add the missing tags? Doesn't look like that's something that I can do via a PR but I believe the below commands should tag the right commits. Where there was a repeat 'Add release x' commit I've tagged the later one since I've assumed it was a correction. I haven't bothered tagging RCs since the CLI filters out prerelease version tags anyway:

git tag version/0.60.1 47267c404884522f6b7210da5019823cb5c5ea40
git tag version/0.60.2 7f1730841ba6771d1c7da457a2996c787d850aed
git tag version/0.60.3 ec6b246ffcf46c68634051772d311ed17d06fbe9
git tag version/0.60.4 cd95fafe95c9358c8a52d626d34b61f5dc2c8baf
git tag version/0.60.5 41f6f9f0e584cfc323c6e20a0b62d212d23d12ea
git tag version/0.60.6 4e0240d631efe6fd8ef33c3b3a1e867c22c4f33b
git tag version/0.61.0 e778eddaa005b56ba24d295e7202a21259ffdb30
git tag version/0.61.1 cd399a6199ba387abe4cc4767f8312ae66544b90
git tag version/0.61.2 ade9d26e271a8a34e9fd9e3c42860ccb500b4262
git tag version/0.61.3 e1929723d356981ad4e33a743adca730ff789cbf
git tag version/0.61.4 36df34061f44060af8ed2bf384d76b579109dc2d
git tag version/0.61.5 4a84e90ca5e2dd8547c328046ebc40b77147dab1
git tag version/0.62.0 ee5ebeb0ba7d4cd42f56b679c8990b536769b686
git tag version/0.62.1 53e28efe18fa1dfbdc6a127d572dc14af201c0bc
git tag version/0.62.2 bf5e7f678bbec4acde46567678cbb703c4135eec
git tag version/0.63.0 e56092a4dd0c264c19bacf821511021629ff927b
git tag version/0.63.1 5843b2fcd282e9052769b8273b6f8b82eca1dba1
git tag version/0.63.2 2ea07482529c6afa5d8c8f698d212cb31c6d6a58
git tag version/0.63.3 77f9715f6c18d57747802c2d082f699f702802f8
git tag version/0.63.4 8aa6c6ae55d1d4ab335cf25fcd6010c47c1e2670
git tag version/0.64.0 96df4a7e0cd59dad97d961a17fe25d252ecf56ef

I've also raised a PR (https://github.com/react-native-community/rn-diff-purge/pull/45) to add tagging to the newRelease.sh script so it doesn't get missed again.

liamjones avatar Apr 05 '21 09:04 liamjones

i think this is fixed now. could you check again?

pvinis avatar Jun 01 '22 17:06 pvinis

Thanks! It wasn't immediately fixed (I hit a secondary bug on react-native-cli that I'll report) but having worked around that it seems to be working now:

yarn workspace v1.22.18
yarn run v1.22.18
$ react-native start --port 9081 --verbose

                        #######
                   ################
                #########     #########
            #########             ##########
        #########        ######        #########
       ##########################################
      #####      #####################       #####
      #####          ##############          #####
      #####    ###       ######       ###    #####
      #####    #######            #######    #####
      #####    ###########    ###########    #####
      #####    ##########################    #####
      #####    ##########################    #####
      #####      ######################     ######
       ######        #############        #######
         #########        ####       #########
              #########          #########
                  ######### #########
                       #########


debug Checking for a newer version of React Native
debug Current version: 0.66.3
debug No release cache found
debug Checking for newer releases on GitHub
                    Welcome to Metro!
              Fast - Scalable - Integrated



To reload the app press "r"
To open developer menu press "d"

debug Latest release: 0.69.0-rc.6

One question though - should it be highlighting rc releases or does a tweak need to be made (either to the cli project or when tagging is/isn't done here)?

liamjones avatar Jun 06 '22 12:06 liamjones

no longer using rn/cli.

pvinis avatar Nov 12 '22 04:11 pvinis