WATCHMAN_VERSION not used

[n4n0lix]

In the Dockerfile there is a line ARG WATCHMAN_VERSION=4.9.0 which is never used.

In the same context, when for example watchman watch-del-all is executed in the container it results in watchman: command not found. But I can still build react-native apps using this docker image.

[michaelgmcd]

We extended this image to add watchman and a few other features: ruby, fastlane, sudo, and procps (needed for this error). If one of the maintainers would like these added to the core image, I can look into making a PR.

Here's the watchman part:

FROM reactnativecommunity/react-native-android

ENV WATCHMAN_VERSION=4.9.0

# Install Watchman
RUN apt-get update \
  && apt-get install -y python python-dev pkg-config libssl-dev autoconf automake libtool \
  && cd /tmp \
  && git clone https://github.com/facebook/watchman.git \
  && cd watchman \
  && git checkout v${WATCHMAN_VERSION} \
  && ./autogen.sh \
  && ./configure \
  && make \
  && make install \
  && cd $HOME \
  && rm -rf /tmp/watchman

[gengjiawen]

@michaelgmcd Feel free to send a PR.

[michaelgmcd]

Sounds good. I'll get to this when time permits!