cli icon indicating copy to clipboard operation
cli copied to clipboard

Published 20 hours ago • verified publisher icon react-native-community

chore: switch to tinyglobby

Open benmccann opened this issue 5 months ago • 1 comments

Summary

https://npmgraph.js.org/?q=fast-glob - 17 dependencies https://npmgraph.js.org/?q=tinyglobby - 2 dependencies

Test Plan

No new functionality was added, so this should be covered by existing tests

Checklist

  • [x] Documentation is up to date.
  • [x] Follows commit message convention described in CONTRIBUTING.md.
  • [x] For functional changes, my test plan has linked these CLI changes into a local react-native checkout (instructions).

benmccann avatar Jun 27 '25 15:06 benmccann

tinyglobby should be faster. Here's a benchmark from their repo:

Screenshot from 2025-06-26 10-28-43

Looks like the CI for this change is failing because Jest is outdated, so we'll either need to upgrade Jest or wait for a new release of fdir containing the commit https://github.com/thecodrr/fdir/commit/76cb3a4ea721e1417d4ffab8061767027b942337 supporting older platforms

benmccann avatar Jun 28 '25 14:06 benmccann

@benmccann any chance you could measure the perf difference in this project?

thymikee avatar Jul 07 '25 15:07 thymikee

I've updated this PR to use the latest tinyglobby, which in turn uses the latest fdir, which removes the usage of AbortController, so this PR should pass on older versions of Node on the CI now

benmccann avatar Sep 09 '25 19:09 benmccann