cli icon indicating copy to clipboard operation
cli copied to clipboard

fix: invalid character in header on Windows

Open szymonrybczak opened this issue 1 year ago • 4 comments

Summary:

Fixes https://github.com/react-native-community/cli/issues/2279 Fixes https://github.com/react-native-community/cli/issues/2449

Some paths to current working directory contains characters that are invalid for header inside the request specifically on Windows - by wrapping path inside URL() class we're sure that characters are correctly coded.

Checklist

  • [x] Documentation is up to date to reflect these changes.
  • [x] Follows commit message convention described in CONTRIBUTING.md

szymonrybczak avatar Aug 30 '24 11:08 szymonrybczak

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

github-actions[bot] avatar Feb 04 '25 03:02 github-actions[bot]

cc @huntie can you take a look if this one doesn't introduce any regressions?

szymonrybczak avatar Feb 04 '25 13:02 szymonrybczak

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

github-actions[bot] avatar May 06 '25 03:05 github-actions[bot]

@szymonrybczak I don't really have a Windows machine to hand, please validate on your end.

huntie avatar May 23 '25 13:05 huntie

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

github-actions[bot] avatar Aug 22 '25 03:08 github-actions[bot]