cli
cli copied to clipboard
react-native-community
chore: upgrade parcel to v2
Summary:
builds correctly but no idea if the config is right, needs to be tested
Test Plan:
- [ ] - builds without errors
- [ ] - works as before
Checklist
- [ ] Documentation is up to date to reflect these changes.
- [ ] Follows commit message convention described in CONTRIBUTING.md
Tested on debugger-ui, works as intended, there are no additional errors in console.
There's something wrong with specifying exports for browser and node environment, @Piotrfj did you remove previous build?
After running rm -rf build && yarn build, /debugger-ui route fails with an error:
PS. I tried specifying targets and exports field but unfortunately I didn't get it working ;/
@szymonrybczak I've done clean install/build on the branch, so I don't think there was any issues with that. @jbroma can you also confirm that the problem issued by @szymonrybczak, I will try to test it soon also
Tested this locally and while building on clear and populated cache works, changing the HTML contents and rebuilding causes SIGSEGV when doing parcel build or just straight not outputting the files to the filesystem (while the Parcel UI states they were built, which I guess is some kind of race condition). Haven't found anything helpful in how to mitigate that other than removing the .parcel-cache folder in project root every time we make a change in HTML.
Provided that we're not going to change this part of the codebase anytime soon (other than deleting it once Experimental Debugger is not experimental anymore), I'm leaning towards merging it as it shouldn't have impact on our users (we publish the build/ folder), just on the contributiors wanting to change stuff there or release the new version that may have some files missing.
thanks for looking into that @thymikee 🎉
perhaps let's just run the build command with --no-cache instead of deleting it, that should always overwrite the contents