cli icon indicating copy to clipboard operation
cli copied to clipboard

fix: use preferred device in default mode

Open szymonrybczak opened this issue 3 months ago • 2 comments

Summary:

In https://github.com/react-native-community/cli/pull/2162 I added preferred device feature - it saves device id to cache, and then when running run-ios command it'll push preferred device to the beginning.

For some strange reason, we only enabled this for --interactive or --list-devices mode. In this Pull Request preferred device is also in default mode.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run run-ios --interactive pick a simulator
  3. Open bunch other simulators
  4. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios
  1. It should pick one that was selected in the interactive prompt.

Checklist

  • [x] Documentation is up to date to reflect these changes.
  • [x] Follows commit message convention described in CONTRIBUTING.md

szymonrybczak avatar Apr 23 '24 10:04 szymonrybczak

For some reason Windows Job is failing - all passes locally.

szymonrybczak avatar Apr 23 '24 16:04 szymonrybczak