cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: RFC-0759: command init for iOS → @react-native/core-cli-utils

Open blakef opened this issue 3 months ago • 3 comments

Summary:

Use the core library for iOS init actions.

[!WARNING] This needs to wait for nightlies to land with the updated TypeScript definitions, expect CI to fail until then.

Test Plan:

Checklist

  • [ ] Documentation is up to date to reflect these changes.
  • [ ] Follows commit message convention described in CONTRIBUTING.md

blakef avatar Mar 15 '24 17:03 blakef

Trying to get my head around the logic of installing pods under various conditions. Is this a temporary step? Because it moves some of the logic to the core, but not most of it.

Other than that and lack of types (which we can ts-expect-error and ship later) it seems to work when linked locally

thymikee avatar Mar 28 '24 16:03 thymikee

Trying to get my head around the logic of installing pods under various conditions. Is this a temporary step? Because it moves some of the logic to the core, but not most of it.

Other than that and lack of types (which we can ts-expect-error and ship later) it seems to work when linked locally

Thanks for taking a look at this @thymikee. Appreciate the feedback. What sort of things would you have expected to move into core that aren't there?

Both flow and TypeScript types ship with the @react-native/core-cli-utils package.

blakef avatar Apr 02 '24 09:04 blakef

Since we have TS typings, can we rebase and hopefully get it merged?

thymikee avatar Apr 17 '24 15:04 thymikee