cli icon indicating copy to clipboard operation
cli copied to clipboard

fix: Fix made to handle if mode in command argument includes build flavor …

Open sakiv opened this issue 1 year ago • 2 comments

Summary:

This change addresses the bug #2323 reported for yarn react-native run-android with product flavor.

Test Plan:

Fix made locally and tested by installing on simulator, please refer below screenshot.

rn-cli-screenshot

Checklist

  • [x] Documentation is up to date to reflect these changes.
  • [x] Follows commit message convention described in CONTRIBUTING.md

sakiv avatar Mar 08 '24 02:03 sakiv

If this is working fine, can we please merge it?

deepak-dpt avatar Jul 16 '24 09:07 deepak-dpt

This fixes my issue installing the app on a device.

zirho avatar Aug 04 '24 18:08 zirho

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

github-actions[bot] avatar Feb 04 '25 03:02 github-actions[bot]

Any chance we can re-open this ticket and get it merged in? Without it, it's hard to use flavors with react native properly.

mylescc avatar Jun 04 '25 12:06 mylescc

Sorry for lagging behind it for so long!

thymikee avatar Jun 04 '25 13:06 thymikee