cli icon indicating copy to clipboard operation
cli copied to clipboard
verified publisher icon react-native-community

Fix: change title

Open finchcn opened this issue 1 year ago • 4 comments

Summary:

replace title placeholder with --title param

Test Plan:

init a new project with --title param, build and install app to device, check app title is same with --title param

Checklist

  • [x] Documentation is up to date to reflect these changes.
  • [x] Follows commit message convention described in CONTRIBUTING.md

finchcn avatar Jan 17 '24 05:01 finchcn

@adamTrz @thymikee please review this PR

finchcn avatar Jan 19 '24 08:01 finchcn

Is this about https://github.com/react-native-community/cli/issues/2146?

thymikee avatar Jan 22 '24 09:01 thymikee

Is this about #2146?

no, this PR fix other file's display name but app.json because content of displayname in app.json is 'HelloWorld' not 'Hello App Display Name' merge this pr, fix replace function for replace all placeholder of displayname and then fix the app.json in template

finchcn avatar Jan 22 '24 11:01 finchcn

@thymikee Can this PR be merged?

finchcn avatar Jan 31 '24 01:01 finchcn

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

github-actions[bot] avatar Apr 30 '24 03:04 github-actions[bot]