cli icon indicating copy to clipboard operation
cli copied to clipboard

doctor: combo check for android gradle plugin < 7.1 iff react-native <= 0.68

Open mikehardy opened this issue 3 years ago • 3 comments

Describe the Feature

Doctor should determine the installed version of react-native (if one is installed), and if react-native is <= 0.68, it should verify that android gradle plugin is < 7.1

Possible Implementations

Unknown, need to experiment

Related Issues

#1554 - discussion of how to handle incompatibilities discovered after a react-native release https://github.com/facebook/react-native/pull/33057 - PR where issue will be resolved

mikehardy avatar Feb 19 '22 13:02 mikehardy

Needs a more fine-grained test if possible, even because of https://issuetracker.google.com/issues/159411906

If new architecture is enabled, android gradle plugin 7.2 will be needed or ./gradlew clean [edited based on good catch from Nicola] fails, but plugin > 7.0 is not okay until react-native 0.69+ so there is a version range + feature set that simply has a known incompatibility, that can be communicated to users though

Noticed in https://github.com/reactwg/react-native-releases/discussions/13#discussioncomment-2255906

mikehardy avatar Mar 02 '22 17:03 mikehardy

clean build fails

To clarify, calling gradle clean will fail. Not a clean build (i.e. building from a clean repo). But yeah, worth to address

cortinico avatar Mar 03 '22 19:03 cortinico

sorry! exactly correct, imprecise wording on my part. I'm going to edit the comment to take this in to account, good catch

mikehardy avatar Mar 03 '22 19:03 mikehardy

There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

github-actions[bot] avatar Nov 26 '22 03:11 github-actions[bot]