cli icon indicating copy to clipboard operation
cli copied to clipboard

support HTTP_PROXY environment

Open lotosbin opened this issue 5 years ago • 5 comments

lotosbin avatar Oct 12 '20 20:10 lotosbin

Thank you for your first contribution. Could you please provide a bit more details, what is that you're trying to accomplish, is there an underlying issue here we can follow for more details?

grabbou avatar Nov 03 '20 14:11 grabbou

somewhere cannot direct access github.com. when using a proxy, Failed to fetch diff. the reason is this react native cli do not use system env HTTP_PROXY to create proxy.

lotosbin avatar Nov 07 '20 02:11 lotosbin

Thanks.

I think that there are a few more factors beyond HTTP_PROXY that we should factor in and unfortunately, node-fetch has no support for it out of the box.

request, on the other hand, does have built-in support for various env variables.

I think it would be quite trivial to change to request, given that we're just using it to fetch a JSON and do not even take advantage of any other library specific features.

What do you think?

grabbou avatar Dec 07 '20 11:12 grabbou

request is too big: https://packagephobia.com/result?p=request

thymikee avatar Dec 07 '20 11:12 thymikee

Let's stick to custom implementation, as in the PR.

grabbou avatar Dec 07 '20 11:12 grabbou

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

github-actions[bot] avatar Nov 27 '22 03:11 github-actions[bot]