react-native-camera-v4 icon indicating copy to clipboard operation
react-native-camera-v4 copied to clipboard

Published 20 hours ago • verified publisher icon react-native-camera

Swift Rewrite

Open MarcoScabbiolo opened this issue 4 years ago • 4 comments

Rewrite the native code for core and barcode in Swift. Exclude any unused code (face detection, etc.), clean up the surface API for ease of usage and review portability with the Android API.

Swiftify can help a lot

MarcoScabbiolo avatar Feb 03 '21 13:02 MarcoScabbiolo

@MarcoScabbiolo while you are at it, you may want to consider also removing some of the deprecated API calls. More specifically, captureStillImageAsynchronouslyFromConnection is deprecated, and so most of the classes related to it (https://developer.apple.com/documentation/avfoundation/avcapturestillimageoutput?language=objc).

Not swift, but here's an example of the code migration for the new API: https://stackoverflow.com/questions/39872528/ios-10-objective-c-how-to-implement-avcapturephotooutput-to-capture-image

cristianoccazinsp avatar Mar 02 '21 00:03 cristianoccazinsp

Is there a plan to remove writeImageDataToSavedPhotosAlbum ? from the deprecated ALAssetsLibrary? Can we help? v4 was released with what seems Android rewrite, but not iOS rewrite, am I right?

raimonkh avatar Sep 30 '21 10:09 raimonkh

@raimonkh Please see: https://github.com/react-native-camera/react-native-camera/issues/3000#issuecomment-933697104 . If anyone wants to keep going with the v4, its all yours, but know that our vision for it is already achieved in react-native-vision-camera

MarcoScabbiolo avatar Oct 04 '21 17:10 MarcoScabbiolo

Thanks @MarcoScabbiolo 👍

raimonkh avatar Oct 04 '21 19:10 raimonkh